Sign upLogin

oliverfarrell/perfbudget

View on GitHub
Star

Showing 4 of 6 total issues

Function runTest has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

var runTest = function(options, callback) {
  options = _.merge( defaultOptions, options );

  var WebPageTest = require('webpagetest'),
      wpt = new WebPageTest(options.wptInstance, options.key),
Severity: Minor
Found in perfbudget.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function runTest has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var runTest = function(options, callback) {
  options = _.merge( defaultOptions, options );

  var WebPageTest = require('webpagetest'),
      wpt = new WebPageTest(options.wptInstance, options.key),
Severity: Major
Found in perfbudget.js - About 3 hrs to fix

    Function exports has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function(argv) {
  options = {
    budget : {}
  }
    Severity: Minor
    Found in lib/normalizeCli.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function processData has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var processData = function(data) {

    var budget = options.budget,
        summary = data.summary,
        median = options.repeatView ? data.median.repeatView : data.median.firstView,
    Severity: Minor
    Found in perfbudget.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language