Sign upLogin

onddo/zookeeper_bridge-cookbook

View on GitHub
Star

Showing 2 of 4 total issues

Method zk_get_hash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def zk_get_hash(path, encoding = nil, force = false)
        # TODO: raise different exceptions for connection errors
        attrs, stat = @zk.get(path)
        attrs = force_encoding(attrs, encoding) unless encoding.nil?
        fail ZkHashFormatError unless attrs.is_a?(String)
Severity: Minor
Found in libraries/zookeeper_bridge_attributes.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method lock_wait_with_class has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def lock_wait_with_class(klass, path, wait, args = [], block)
Severity: Minor
Found in libraries/zookeeper_bridge_locker.rb - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language