Sign upLogin

onejgordon/flow-dashboard

View on GitHub
Star
src/js/utils/util.js

Summary

Maintainability
F
4 days
Test Coverage

util has 75 functions (exceeds 20 allowed). Consider refactoring.
Open

var util = {

    ListPop: function(keyval, list, _key) {
        var key = _key || "id";
        for (var i=0; i<list.length; i++) {
Severity: Major
Found in src/js/utils/util.js - About 1 day to fix

    File util.js has 592 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var $ = require('jquery');
var moment = require('moment-timezone');
import {findIndexById} from 'utils/store-utils';

var util = {
    Severity: Major
    Found in src/js/utils/util.js - About 1 day to fix

      Function initAppCache has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          initAppCache: function() {
        appCache = window.applicationCache;
        appCache.addEventListener('updateready', function(e) {
            if (appCache.status == appCache.UPDATEREADY) {
                // Browser downloaded a new app cache.
      Severity: Minor
      Found in src/js/utils/util.js - About 1 hr to fix

        Function printDateObj has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            printDateObj: function(date, _timezone, opts) {
        if (_timezone && moment) {
            // Using moment.js to print local date/times
            let dt = moment.tz(date.getTime(), _timezone);
            let format = "YYYY-MM-DD";
        Severity: Minor
        Found in src/js/utils/util.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function timesince has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            timesince(ms) {
        let LEVELS = [
            { label: "second", cutoff: 60, recent: true, seconds: 1 },
            { label: "minute", cutoff: 60, seconds: 60 },
            { label: "hour", cutoff: 24, seconds: 60*60 },
        Severity: Minor
        Found in src/js/utils/util.js - About 1 hr to fix

          Function arrEquals has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              arrEquals: function(array, array2) {
        // if the other array is a falsy value, return
        if (!array)
            return false;
          Severity: Minor
          Found in src/js/utils/util.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function notify has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              notify(message, body, tag, icon) {
      let opts = {
        body: body,
        icon: icon || '/images/logo_128.png',
      };
          Severity: Minor
          Found in src/js/utils/util.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function timesince has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              timesince(ms) {
        let LEVELS = [
            { label: "second", cutoff: 60, recent: true, seconds: 1 },
            { label: "minute", cutoff: 60, seconds: 60 },
            { label: "hour", cutoff: 24, seconds: 60*60 },
          Severity: Minor
          Found in src/js/utils/util.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function onerror has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  window.onerror = function(msg, url, line, col, error) {
          Severity: Minor
          Found in src/js/utils/util.js - About 35 mins to fix

            Avoid too many return statements within this function.
            Open

                    return true;
            Severity: Major
            Found in src/js/utils/util.js - About 30 mins to fix

              Function colorInterpolate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  colorInterpolate: function(opts) {
        // Takes opts
        // color1, color2 - hex without # e.g. 'FF0000'
        // min, max, value, from which ratio is calculated
        // OR
              Severity: Minor
              Found in src/js/utils/util.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function sum has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  sum: function(arr) {
        // Of non-null
        let sum = 0;
        let count = 0;
        if (arr.length > 0) {
              Severity: Minor
              Found in src/js/utils/util.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      var r = Math.ceil(parseInt(color2.substring(0,2), 16) * ratio + parseInt(color1.substring(0,2), 16) * (1-ratio));
              Severity: Major
              Found in src/js/utils/util.js and 2 other locations - About 1 hr to fix
              src/js/utils/util.js on lines 81..81
              src/js/utils/util.js on lines 82..82

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      var g = Math.ceil(parseInt(color2.substring(2,4), 16) * ratio + parseInt(color1.substring(2,4), 16) * (1-ratio));
              Severity: Major
              Found in src/js/utils/util.js and 2 other locations - About 1 hr to fix
              src/js/utils/util.js on lines 80..80
              src/js/utils/util.js on lines 82..82

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      var b = Math.ceil(parseInt(color2.substring(4,6), 16) * ratio + parseInt(color1.substring(4,6), 16) * (1-ratio));
              Severity: Major
              Found in src/js/utils/util.js and 2 other locations - About 1 hr to fix
              src/js/utils/util.js on lines 80..80
              src/js/utils/util.js on lines 81..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 59.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status