Sign upLogin

onijim/owl-table

View on GitHub
Star
src/services/owlTableService.js

Summary

Maintainability
F
3 days
Test Coverage

Function owlTableService has 384 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function owlTableService ($http, $rootScope, $filter, $modal, owlConstants, owlResource, owlUtils, owlFilter) {
        var unrenderedTable;

        var service = {
            tables: [],
Severity: Major
Found in src/services/owlTableService.js - About 1 day to fix

    File owlTableService.js has 402 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function (angular, _, $, React, OwlTableReact) {
    'use strict';

    function owlTableService ($http, $rootScope, $filter, $modal, owlConstants, owlResource, owlUtils, owlFilter) {
        var unrenderedTable;
    Severity: Minor
    Found in src/services/owlTableService.js - About 5 hrs to fix

      Function initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              service.initialize = function (settings) {
            //this.data = settings.data;
            this.columns = settings.columns;
            this.childColumns = settings.childColumns;
            this.options = _.defaults(settings.options, defaults.options);
      Severity: Minor
      Found in src/services/owlTableService.js - About 1 hr to fix

        Function customizeColumns has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                service.customizeColumns = function () {
            var self = this;

            var modal = $modal.open({
                templateUrl: 'partials/columnModal.html',
        Severity: Minor
        Found in src/services/owlTableService.js - About 1 hr to fix

          Function owlTableService has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function owlTableService ($http, $rootScope, $filter, $modal, owlConstants, owlResource, owlUtils, owlFilter) {
          Severity: Major
          Found in src/services/owlTableService.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        var ourRow = owlUtils.firstRowIfExists(
                _.filter(this.data, function (datum) {
                    /* jshint ignore:start */
                    return datum.id == rowId;
                    /* jshint ignore:end */
            Severity: Minor
            Found in src/services/owlTableService.js and 1 other location - About 40 mins to fix
            src/services/owlTableService.js on lines 379..385

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        var ourRow = owlUtils.firstRowIfExists(
                _.filter(this.data, function (datum) {
                    /* jshint ignore:start */
                    return datum.id == rowId;
                    /* jshint ignore:end */
            Severity: Minor
            Found in src/services/owlTableService.js and 1 other location - About 40 mins to fix
            src/services/owlTableService.js on lines 360..366

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status