onlyurei/knockout-spa

View on GitHub

Showing 18 of 113 total issues

Function call has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    call: function (apiPackage, apiMethod, urlParams, data, error, loading, synchronousOrSocket) {
      var api = Api.list[apiPackage][apiMethod];

      if (!api) {
        return $.Deferred().reject('Api not found.');
Severity: Major
Found in app/shared/api/api.js - About 3 hrs to fix

    Function constructor has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        constructor: function (
          name, value, required, validations, useCurrentPosition, submitOnChange, initFromQueryString, autocomplete) {
          FormInputLocation.$super.call(this, name, value, required, validations, submitOnChange, initFromQueryString);
    
          this.currentPosition = ko.observable(null);
    Severity: Major
    Found in widget/form/form-input-location.js - About 2 hrs to fix

      Function constructor has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor: function (name, value, required, validations, submitOnChange, initFromQueryString) {
            this.name = name;
            this.value = ko.isObservable(value) ? value : ko.observable(Object.isFunction(value) ? value() : ((value !== undefined) ? value : ''));
            if (initFromQueryString) {
              this.fromQueryString();
      Severity: Major
      Found in widget/form/form-input.js - About 2 hrs to fix

        Function init has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            init: function (element, valueAccessor, allBindingsAccessor) {
              var value = ko.utils.unwrapObservable(valueAccessor()), allBindings = allBindingsAccessor();
              if (!Object.isEmpty(value)) {
                require(['cytoscape'], function (cytoscape) {
                  var cy = cytoscape(Object.merge({
        Severity: Major
        Found in lib-ext/knockout-custom-bindings-lib.js - About 2 hrs to fix

          Function init has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              init: function (name, data, path, controller) {
                this.loading = false;
          
                name = name.toLowerCase();
          
          
          Severity: Minor
          Found in framework/page.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if (href && !href.startsWith('#') && ((origin === window.location.origin) || !origin) &&
                    ($(this).attr('target') != '_blank') && !$(this).data('go') && !event.ctrlKey && !event.metaKey) {
                  event.preventDefault();
                  Page.loading = true;
                  router.setRoute(href);
            Severity: Critical
            Found in framework/router.js - About 1 hr to fix

              Function constructor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  constructor: function (inputs, submit, initFromQueryString) {
                    this.inputs = {};
                    if (Object.isObject(inputs)) {
                      this.inputs = inputs;
                    } else if (Object.isArray(inputs)) {
              Severity: Minor
              Found in widget/form/form.js - About 1 hr to fix

                Function getCurrentPosition has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    getCurrentPosition: function (successCallback, errCallback) {
                      if (this.geolocationAvailable) {
                        this.gettingCurrentPosition(true);
                        this.currentPosition(null);
                        navigator.geolocation.getCurrentPosition(
                Severity: Minor
                Found in widget/form/form-input-location.js - About 1 hr to fix

                  Function flatten has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function flatten(object) {
                      var result = {};
                  
                      function recurse(cur, prop) {
                        if (Object(cur) !== cur) {
                  Severity: Minor
                  Found in util/json.js - About 1 hr to fix

                    Consider simplifying this complex logical expression.
                    Open

                          if (Object.isObject(synchronousOrSocket)) {
                    
                            var deferred = $.Deferred();
                    
                            require(['io'], function (io) {
                    Severity: Major
                    Found in app/shared/api/api.js - About 1 hr to fix

                      Function constructor has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            name, value, required, validations, useCurrentPosition, submitOnChange, initFromQueryString, autocomplete) {
                      Severity: Major
                      Found in widget/form/form-input-location.js - About 1 hr to fix

                        Function call has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            call: function (apiPackage, apiMethod, urlParams, data, error, loading, synchronousOrSocket) {
                        Severity: Major
                        Found in app/shared/api/api.js - About 50 mins to fix

                          Function constructor has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              constructor: function (name, value, required, validations, submitOnChange, initFromQueryString) {
                          Severity: Minor
                          Found in widget/form/form-input.js - About 45 mins to fix

                            Function getDistanceFromLatLon has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                getDistanceFromLatLon: function (latitude1, longitude1, latitude2, longitude2, metric) {
                            Severity: Minor
                            Found in util/geolocation.js - About 35 mins to fix

                              Function makeErrorJson has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                function makeErrorJson(message, file, line, column, error) {
                              Severity: Minor
                              Found in util/error-reporter.js - About 35 mins to fix

                                Function onerror has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                  window.onerror = function (message, file, line, column, error) {
                                Severity: Minor
                                Found in util/error-reporter.js - About 35 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                                  return false;
                                  Severity: Major
                                  Found in widget/form/form-input.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                              return ajax;
                                    Severity: Major
                                    Found in app/shared/api/api.js - About 30 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language