opal/opal

File runtime.js has 2000 lines of code (exceeds 1000 allowed). Consider refactoring.

Open

(function(global_object) {
  "use strict";

  // @note
  //   A few conventions for the documentation of this file:

Function $allocate_class has 54 lines of code (exceeds 30 allowed). Consider refactoring.

Open

  function $allocate_class(name, superclass, singleton) {
    var klass, bridged_descendant;

    if (bridged_descendant = descends_from_bridged_class(superclass)) {
      // Inheritance from bridged classes requires

Function prepend_features has 47 lines of code (exceeds 30 allowed). Consider refactoring.

Invalid

  Opal.prepend_features = function(module, prepender) {
    // Here we change the ancestors chain from
    //
    //   prepender
    //      |

Function hash has 44 lines of code (exceeds 30 allowed). Consider refactoring.

Open

  Opal.hash = function () {
    var arguments_length = arguments.length,
      args,
      hash,
      i,

Function klass has 42 lines of code (exceeds 30 allowed). Consider refactoring.

Wontfix

  Opal.klass = function(scope, superclass, name) {
    var bridged;

    if (scope == null || scope == '::') {
      // Global scope

Function append_features has 42 lines of code (exceeds 30 allowed). Consider refactoring.

Wontfix

  Opal.append_features = function(module, includer) {
    var module_ancestors = $ancestors(module);
    var iclasses = [];

    if (module_ancestors.indexOf(includer) !== -1) {

Function alias has 31 lines of code (exceeds 30 allowed). Consider refactoring.

Open

  Opal.alias = function(obj, name, old) {
    var id     = $jsid(name),
        old_id = $jsid(old),
        body,
        alias;

Function refined_send has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

  Opal.refined_send = function(refinement_groups, recv, method, args, block, blockopts) {

Avoid deeply nested control flow statements.

Wontfix

            if (objects.length === 0)
              hash.$$keys.delete(key_hash);

Function send2 has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

  Opal.send2 = function(recv, body, method, args, block, blockopts) {

Avoid deeply nested control flow statements.

Wontfix

            if (subclass.deref() !== undefined) {
              rebuilt_subclasses.push(subclass);
            }

Function send has 5 arguments (exceeds 4 allowed). Consider refactoring.

Wontfix

  Opal.send = function(recv, method, args, block, blockopts) {

Function find_super has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  Opal.find_super = function(obj, mid, current_func, defcheck, allow_stubs) {

Function find_block_super has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  Opal.find_block_super = function(obj, jsid, current_func, defcheck, implicit) {

Avoid too many return statements within this function.

Wontfix

    return Opal.send(object, method, args);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (value.$$is_array) {
      return value;
    }
    else if (value['$respond_to?']('to_ary', true)) {
      var ary = value.$to_ary();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if (value.$$is_array) {
      // A splatted array must be copied
      return value.slice();
    }
    else if (value['$respond_to?']('to_a', true)) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

    if (obj.$$is_singleton) {
      if (obj.$$prototype.$singleton_method_undefined && !obj.$$prototype.$singleton_method_undefined.$$stub) {
        obj.$$prototype.$singleton_method_undefined(jsid.substr(1));
      }
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

    if (obj.$$is_singleton) {
      if (obj.$$prototype.$singleton_method_removed && !obj.$$prototype.$singleton_method_removed.$$stub) {
        obj.$$prototype.$singleton_method_removed(jsid.substr(1));
      }
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

    for (var i = 0, length = module_ancestors.length; i < length; i++) {
      var ancestor = module_ancestors[i], iclass = create_iclass(ancestor);
      $prop(iclass, '$$included', true);
      iclasses.push(iclass);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Wontfix

    for (var i = 0, length = module_ancestors.length; i < length; i++) {
      var ancestor = module_ancestors[i], iclass = create_iclass(ancestor);
      $prop(iclass, '$$prepended', true);
      iclasses.push(iclass);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      var key_hash = key.$$is_string ? key.valueOf() : (hash.$$by_identity ? Opal.id(key) : key.$hash()),
          objects = hash.$$keys.get(key_hash),
          object;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      var key_hash = key.$$is_string ? key.valueOf() : (hash.$$by_identity ? Opal.id(key) : key.$hash()),
          objects = hash.$$keys.get(key_hash),
          object;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (Opal.is_method(prop)) {
          var method = proto[prop];

          if (!method.$$stub) {
            var method_name = prop.slice(1);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      if (Opal.is_method(prop)) {
        var method = proto[prop];

        if (!method.$$stub) {
          var method_name = prop.slice(1);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  Opal.neqeq = function(lhs, rhs) {
    return are_both_numbers_or_strings(lhs,rhs) ? lhs !== rhs : $truthy((lhs)['$!='](rhs));
  };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  Opal.eqeqeq = function(lhs, rhs) {
    return are_both_numbers_or_strings(lhs,rhs) ? lhs === rhs : $truthy((lhs)['$==='](rhs));
  };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Invalid

    if ((cache = nesting.$$const_cache) == null) {
      $prop(nesting, '$$const_cache', Object.create(null));
      cache = nesting.$$const_cache;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Invalid

    if ((cache = cref.$$const_cache) == null) {
      $prop(cref, '$$const_cache', Object.create(null));
      cache = cref.$$const_cache;
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Wontfix

    if (!cref.$$is_module && !cref.$$is_class) {
      $raise(Opal.TypeError, cref.toString() + " is not a class/module");
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Wontfix

    if (!cref.$$is_module && !cref.$$is_class) {
      $raise(Opal.TypeError, cref.toString() + " is not a class/module");
    }

• Read up
  Read up