open-learning-exchange/planet

View on GitHub
design/users/_auth.js

Summary

Maintainability
A
0 mins
Test Coverage

Function validate_doc_update has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
Invalid

  function(newDoc, oldDoc, userCtx, secObj) {
    if (newDoc._deleted === true) {
      // allow deletes by admins and matching users
      // without checking the other fields
      // and forbid deleting admin's user doc
Severity: Minor
Found in design/users/_auth.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_doc_update has 130 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

  function(newDoc, oldDoc, userCtx, secObj) {
    if (newDoc._deleted === true) {
      // allow deletes by admins and matching users
      // without checking the other fields
      // and forbid deleting admin's user doc
Severity: Major
Found in design/users/_auth.js - About 5 hrs to fix

    There are no issues that match your filters.

    Category
    Status