openSUSE/osem

View on GitHub

Showing 83 of 151 total issues

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def initialize(conference, user, physical_ticket, ticket_layout, file_name)
Severity: Minor
Found in app/pdfs/ticket_pdf.rb - About 35 mins to fix

    Method dates_within_conference_dates has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def dates_within_conference_dates
        return unless start_date && end_date && program.try(:conference).try(:start_date) && program.try(:conference).try(:end_date)
    
        errors.add(:start_date, "can't be outside of the conference's dates (#{program.conference.start_date}-#{program.conference.end_date})") unless (program.conference.start_date..program.conference.end_date).cover?(start_date)
        errors.add(:end_date, "can't be outside of the conference's dates (#{program.conference.start_date}-#{program.conference.end_date})") unless (program.conference.start_date..program.conference.end_date).cover?(end_date)
    Severity: Minor
    Found in app/models/track.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method show has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def show
          @event_schedules = @schedule.event_schedules.eager_load(
            room:  :tracks,
            event: [
              :difficulty_level,
    Severity: Minor
    Found in app/controllers/admin/schedules_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method revert_object has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def revert_object
          if @version.event != 'create'
            if @version.reify.save
              flash[:notice] = 'The selected change was successfully reverted'
            else
    Severity: Minor
    Found in app/controllers/admin/versions_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method current_or_last_object_state has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def current_or_last_object_state(model_name, id)
        return nil unless id.present? && model_name.present?
    
        begin
          object = model_name.constantize.find_by(id: id)
    Severity: Minor
    Found in app/helpers/versions_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
        current_user.ticket_purchases.by_conference(@conference).unpaid.destroy_all
        message = TicketPurchase.purchase(@conference, current_user, params[:tickets].try(:first))
        if message.blank?
          if current_user.ticket_purchases.by_conference(@conference).unpaid.any?
    Severity: Minor
    Found in app/controllers/ticket_purchases_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_values has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_values(conference, user, event = nil, booth = nil)
        h = {
          'email'                  => user.email,
          'name'                   => user.name,
          'conference'             => conference.title,
    Severity: Minor
    Found in app/models/email_settings.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method withdraw has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def withdraw
        authorize! :update, @event
        @url = conference_program_proposal_path(@conference.short_title, params[:id])
    
        begin
    Severity: Minor
    Found in app/controllers/proposals_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_roles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_roles
        result = {}
        roles.each do |role|
          resource = if role.resource_type == 'Conference'
                       Conference.find(role.resource_id).short_title
    Severity: Minor
    Found in app/models/user.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_logo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_logo(object)
        if object.try(:sponsorship_level)
          if object.sponsorship_level.position == 1
            object.picture.first.url
          elsif object.sponsorship_level.position == 2
    Severity: Minor
    Found in app/helpers/application_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_state has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def update_state(transition, mail = false, subject = false, send_mail = false, send_mail_param)
        alert = ''
        if mail && send_mail_param && subject && send_mail
          alert = 'Update Email Subject before Sending Mails'
        end
    Severity: Minor
    Found in app/models/event.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method carousel_item_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def carousel_item_class(number, carousel_number, num_cols, col)
        item_class = 'item'
        item_class += ' first' if number == 0
        item_class += ' last' if number == (carousel_number - 1)
        if (col && ((col / num_cols) == number)) || (!col && number == 0)
    Severity: Minor
    Found in app/helpers/format_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method notify_on_dates_changed? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def notify_on_dates_changed?
        return false unless email_settings.send_on_conference_dates_updated
        # do not notify unless one of the dates changed
        return false unless saved_change_to_start_date? || saved_change_to_end_date?
    
    
    Severity: Minor
    Found in app/models/conference.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(user)
        user ||= User.new
    
        if user.new_record?
          not_signed_in
    Severity: Minor
    Found in app/models/ability.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method notify_on_venue_changed? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def notify_on_venue_changed?
        return false unless conference.try(:email_settings).try(:send_on_venue_updated)
        # do not notify unless the address changed
        return false unless saved_change_to_name? || saved_change_to_street? || saved_change_to_city? || saved_change_to_country?
    
    
    Severity: Minor
    Found in app/models/venue.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_submissions_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_submissions_data
        return [] unless program&.cfp && program&.events
    
        start_week = program.cfp.start_week
        get_events_per_week_by_state.collect do |state, values|
    Severity: Minor
    Found in app/models/conference.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method affiliation_distribution has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def affiliation_distribution
        counted_affiliations = registrations.joins(:user).group(:affiliation).count
        result = {}
        i = 1
        others = 0
    Severity: Minor
    Found in app/models/conference.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method after_sign_in_path_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def after_sign_in_path_for(_resource)
        if (can? :view, Conference) &&
          (!session[:return_to] ||
          session[:return_to] &&
          session[:return_to] == root_path)
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method confirm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def confirm
        authorize! :update, @event
        @url = conference_program_proposal_path(@conference.short_title, params[:id])
    
        begin
    Severity: Minor
    Found in app/controllers/proposals_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def update
          message = ''
          if params[:user] && !params[:user][:email].nil?
            if (new_email = params[:user][:email]) != @user.email
              message = " Confirmation email sent to #{new_email}. The new email needs to be confirmed before it can be used."
    Severity: Minor
    Found in app/controllers/admin/users_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language