Sign upLogin

openc/turbot-client

View on GitHub
Star

Showing 13 of 13 total issues

Method validate has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def validate
    validate_arguments!
    error_if_no_local_bot_found

    manifest = parse_manifest
Severity: Minor
Found in lib/turbot/command/bots.rb - About 1 hr to fix

    Method ask_for_password_on_windows has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def ask_for_password_on_windows
      require 'Win32API'

      password = ''
    Severity: Minor
    Found in lib/turbot/helpers/shell_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare_run has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.prepare_run(cmd, args=[])
      command = commands[cmd] || commands[command_aliases[cmd]]
      @current_command = cmd

      opts = {}
    Severity: Minor
    Found in lib/turbot/command.rb - About 1 hr to fix

      Method generate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def generate
    validate_arguments!
    error_if_bot_exists_in_turbot

    # Check the bot name.
      Severity: Minor
      Found in lib/turbot/command/bots.rb - About 1 hr to fix

        Method preview has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def preview
    validate_arguments!
    error_if_no_local_bot_found

    response = api.update_bot(bot, parse_manifest)
        Severity: Minor
        Found in lib/turbot/command/bots.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method preview has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def preview
    validate_arguments!
    error_if_no_local_bot_found

    response = api.update_bot(bot, parse_manifest)
        Severity: Minor
        Found in lib/turbot/command/bots.rb - About 1 hr to fix

          Method format_error has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def format_error(error, message = 'Turbot client internal error.')
      formatted_error = []
      formatted_error << " !    #{message}"
      formatted_error << ' !    Report a bug at: https://github.com/openc/turbot-client/issues/new'
      formatted_error << ''
          Severity: Minor
          Found in lib/turbot/helpers.rb - About 1 hr to fix

            Method validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def validate
    validate_arguments!
    error_if_no_local_bot_found

    manifest = parse_manifest
            Severity: Minor
            Found in lib/turbot/command/bots.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method prepare_run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def self.prepare_run(cmd, args=[])
      command = commands[cmd] || commands[command_aliases[cmd]]
      @current_command = cmd

      opts = {}
            Severity: Minor
            Found in lib/turbot/command.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method generate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def generate
    validate_arguments!
    error_if_bot_exists_in_turbot

    # Check the bot name.
            Severity: Minor
            Found in lib/turbot/command/bots.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method push has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def push
    validate_arguments!
    error_if_no_local_bot_found

    unless options[:yes]
            Severity: Minor
            Found in lib/turbot/command/bots.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method format_error has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def format_error(error, message = 'Turbot client internal error.')
      formatted_error = []
      formatted_error << " !    #{message}"
      formatted_error << ' !    Report a bug at: https://github.com/openc/turbot-client/issues/new'
      formatted_error << ''
            Severity: Minor
            Found in lib/turbot/helpers.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def self.run(command, arguments=[])
      object, method = prepare_run(command, arguments.dup)
      object.send(method)
    rescue SocketError => e
      error 'Unable to connect to Turbot API, please check internet connectivity and try again.'
            Severity: Minor
            Found in lib/turbot/command.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language