Showing 84 of 154 total issues
Method new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def new
set_up_steps
@question = Question.new(state: @state_code)
@question.user = user_signed_in? ? current_user : User.new
@question.user.for_new_question = true- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method guess_office_level has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def guess_office_level(office, division)
if office.is_governor? || office.is_state_legislator?
GoogleCivicInfo::Office::STATE
elsif office.is_federal_legislator? || office.is_federal_executive_or_judicial?
GoogleCivicInfo::Office::FEDERAL- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method copy_to_new_person has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def copy_to_new_person
unless Metadatum.where(id: state).first
copy_to_new_metadatum
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def run(data)
data.each do |key, value|
case key
when SunlightCongressLegislatorService.new.id_field
self.id = value- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"