openpolitics/groupthink

View on GitHub

Showing 4 of 6 total issues

Class EditController has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class EditController < ApplicationController
  before_action :get_parameters
  before_action :check_logged_in

  extend Memoist
Severity: Minor
Found in app/controllers/edit_controller.rb - About 2 hrs to fix

Method commit_file has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def commit_file(repo, name, content, message, base_sha, branch_name)
Severity: Minor
Found in app/controllers/edit_controller.rb - About 45 mins to fix

Method get_parameters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def get_parameters
      @owner = params[:owner]
      @repo = params[:repo]
      @branch = params[:branch]
      @title = params[:title]
Severity: Minor
Found in app/controllers/edit_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method open_state has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def open_state
      return nil if pr_closed?
      return "dead" if too_old?
      return "blocked" if blocked?
      if passed?
Severity: Minor
Found in app/models/proposal.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language