Sign upLogin

opensheetmusicdisplay/opensheetmusicdisplay

View on GitHub
Star
src/VexFlowPatch/src/gracenotegroup.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function format has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  static format(gracenote_groups, state) {
    const group_spacing_stave = 0; // overwritten later in `spacing` (vexflowpatch)
    const group_spacing_tab = 0;
    // vexflow calls these spacing, though they seem more like margins to be precise. -> EngravingRules.GraceNoteGroupXMargin
Severity: Minor
Found in src/VexFlowPatch/src/gracenotegroup.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function format has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static format(gracenote_groups, state) {
    const group_spacing_stave = 0; // overwritten later in `spacing` (vexflowpatch)
    const group_spacing_tab = 0;
    // vexflow calls these spacing, though they seem more like margins to be precise. -> EngravingRules.GraceNoteGroupXMargin
Severity: Minor
Found in src/VexFlowPatch/src/gracenotegroup.js - About 1 hr to fix

    Function draw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      draw() {
    this.checkContext();

    const note = this.getNote();
    Severity: Minor
    Found in src/VexFlowPatch/src/gracenotegroup.js - About 1 hr to fix

      Function draw has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        draw() {
    this.checkContext();

    const note = this.getNote();
      Severity: Minor
      Found in src/VexFlowPatch/src/gracenotegroup.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status