Sign upLogin

opensheetmusicdisplay/opensheetmusicdisplay

View on GitHub
Star
src/VexFlowPatch/src/stave.js

Summary

Maintainability
F
4 days
Test Coverage

Stave has 67 functions (exceeds 20 allowed). Consider refactoring.
Open

export class Stave extends Element {
  constructor(x, y, width, options) {
    super();
    this.setAttribute('type', 'Stave');
Severity: Major
Found in src/VexFlowPatch/src/stave.js - About 1 day to fix

    File stave.js has 573 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // [VexFlow](http://vexflow.com) - Copyright (c) Mohit Muthanna 2010.

import { Vex } from './vex';
import { Element } from './element';
import { Flow } from './tables';
    Severity: Major
    Found in src/VexFlowPatch/src/stave.js - About 1 day to fix

      Function format has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
      Open

        format() {
    const begBarline = this.modifiers[0];
    const endBarline = this.modifiers[1];

    const begModifiers = this.getModifiers(StaveModifier.Position.BEGIN);
      Severity: Minor
      Found in src/VexFlowPatch/src/stave.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function format has 87 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        format() {
    const begBarline = this.modifiers[0];
    const endBarline = this.modifiers[1];

    const begModifiers = this.getModifiers(StaveModifier.Position.BEGIN);
      Severity: Major
      Found in src/VexFlowPatch/src/stave.js - About 3 hrs to fix

        Function constructor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor(x, y, width, options) {
    super();
    this.setAttribute('type', 'Stave');

    this.x = x;
        Severity: Minor
        Found in src/VexFlowPatch/src/stave.js - About 1 hr to fix

          Function draw has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            draw() {
    this.checkContext();
    this.setRendered();

    if (!this.formatted) this.format();
          Severity: Minor
          Found in src/VexFlowPatch/src/stave.js - About 1 hr to fix

            Function formatBegModifiers has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              formatBegModifiers(staves) {
    let maxX = 0;
    // align note start
    staves.forEach((stave) => {
      if (stave.getNoteStartX() > maxX) maxX = stave.getNoteStartX();
            Severity: Minor
            Found in src/VexFlowPatch/src/stave.js - About 1 hr to fix

              Function draw has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                draw() {
    this.checkContext();
    this.setRendered();

    if (!this.formatted) this.format();
              Severity: Minor
              Found in src/VexFlowPatch/src/stave.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function sortByCategory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                sortByCategory(items, order) {
    for (let i = items.length - 1; i >= 0; i--) {
      for (let j = 0; j < i; j++) {
        if (order[items[j].getCategory()] > order[items[j + 1].getCategory()]) {
          const temp = items[j];
              Severity: Minor
              Found in src/VexFlowPatch/src/stave.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  staves.forEach((stave) => {
      if (stave.getNoteStartX() > maxX) maxX = stave.getNoteStartX();
    });
              Severity: Minor
              Found in src/VexFlowPatch/src/stave.js and 1 other location - About 30 mins to fix
              src/VexFlowPatch/src/stave.js on lines 108..110

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    modifiers.forEach((modifier) => {
        if (modifier.getX() > maxX) maxX = modifier.getX();
      });
              Severity: Minor
              Found in src/VexFlowPatch/src/stave.js and 1 other location - About 30 mins to fix
              src/VexFlowPatch/src/stave.js on lines 81..83

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status