Sign upLogin

openstreetmap-si/GursAddressesForOSM

View on GitHub
Star

Showing 2 of 8 total issues

Function readShapefileToMap has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func readShapefileToMap(shapeFileName string, keyColumnName, valueColumnName string) map[string]string {
    result := make(map[string]string)

    shapeReader, err := shp.Open(shapeFileName)
    if err != nil {
Severity: Minor
Found in gursShp2geoJson.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if !loaded {
                        log.Printf("Possible new abbreviation in %s: %s,%s", valueColumnName, valueUtf, valueUtf)
                    }
Severity: Major
Found in gursShp2geoJson.go - About 45 mins to fix
    Severity
    Category
    Status
    Source
    Language