Sign upLogin

opf/openproject

View on GitHub
Star
frontend/src/stimulus/controllers/dynamic/backlogs/model.js

Summary

Maintainability
F
3 days
Test Coverage

Function Model has 329 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RB.Model = (function ($) {
  return RB.Object.create({

    initialize: function (el) {
      this.$ = $(el);
Severity: Major
Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js - About 1 day to fix

    Function Model has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

    RB.Model = (function ($) {
  return RB.Object.create({

    initialize: function (el) {
      this.$ = $(el);
    Severity: Minor
    Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File model.js has 331 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //-- copyright
// OpenProject is an open source project management software.
// Copyright (C) 2012-2024 the OpenProject GmbH
//
// This program is free software; you can redistribute it and/or
    Severity: Minor
    Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js - About 3 hrs to fix

      Function edit has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          edit: function () {
      var editor = this.getEditor(),
          self = this,
          maxTabIndex = 0;
      Severity: Major
      Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js - About 2 hrs to fix

        Function displayEditor has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            displayEditor: function (editor) {
      var self = this,
          baseClasses;

      baseClasses = 'ui-button ui-widget ui-state-default ui-corner-all';
        Severity: Minor
        Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js - About 1 hr to fix

          Function saveEdits has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              saveEdits: function () {
      var j = this.$,
          self = this,
          editors = j.find('.editor'),
          saveDir;
          Severity: Minor
          Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js - About 1 hr to fix

            Function prepareInputFromFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                prepareInputFromFactory: function (input, fieldId, fieldName, fieldOrder, maxTabIndex, fieldEditable) {
            Severity: Minor
            Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      {
          text: 'Cancel',
          class: 'button',
          click: function () {
            self.cancelEdit();
              Severity: Minor
              Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js and 1 other location - About 35 mins to fix
              frontend/src/stimulus/controllers/dynamic/backlogs/model.js on lines 106..113

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      {
          text: 'OK',
          class: 'button -primary',
          click: function () {
            self.copyFromDialog();
              Severity: Minor
              Found in frontend/src/stimulus/controllers/dynamic/backlogs/model.js and 1 other location - About 35 mins to fix
              frontend/src/stimulus/controllers/dynamic/backlogs/model.js on lines 114..121

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status