Sign upLogin

opf/openproject

View on GitHub
Star

Showing 1,042 of 1,682 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public get gridEndColumn() {
    if (this.isRow) {
      return this.endColumn * 2 - 1;
    }
    return this.endColumn * 2 - 2;
Severity: Minor
Found in frontend/src/app/shared/components/grids/areas/grid-gap.ts and 1 other location - About 40 mins to fix
frontend/src/app/shared/components/grids/areas/grid-gap.ts on lines 19..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export class PrincipalsStore extends EntityStore<PrincipalsState> {
  constructor() {
    super(createInitialResourceState());
  }
}
Severity: Major
Found in frontend/src/app/core/state/principals/principals.store.ts and 16 other locations - About 40 mins to fix
frontend/src/app/core/state/attachments/attachments.store.ts on lines 36..40
frontend/src/app/core/state/capabilities/capabilities.store.ts on lines 9..13
frontend/src/app/core/state/days/day.store.ts on lines 15..19
frontend/src/app/core/state/days/weekday.store.ts on lines 15..19
frontend/src/app/core/state/file-links/file-links.store.ts on lines 36..40
frontend/src/app/core/state/in-app-notifications/in-app-notifications.store.ts on lines 9..13
frontend/src/app/core/state/project-storages/project-storages.store.ts on lines 37..41
frontend/src/app/core/state/projects/projects.store.ts on lines 9..13
frontend/src/app/core/state/storages/storages.store.ts on lines 36..40
frontend/src/app/core/state/views/views.store.ts on lines 9..13
frontend/src/app/features/enterprise/enterprise-trial.store.ts on lines 17..21
frontend/src/app/features/in-app-notifications/bell/state/ian-bell.store.ts on lines 17..21
frontend/src/app/features/in-app-notifications/center/state/ian-center.store.ts on lines 44..48
frontend/src/app/features/user-preferences/state/user-preferences.store.ts on lines 58..62
frontend/src/app/features/work-packages/routing/wp-view-base/state/wp-single-view.store.ts on lines 19..23
modules/github_integration/frontend/module/state/github-pull-request.store.ts on lines 12..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  public get state():InputState<this> {
    return this.states.users.get(this.href as string) as any;
  }
Severity: Major
Found in frontend/src/app/features/hal/resources/user-resource.ts and 4 other locations - About 40 mins to fix
frontend/src/app/features/hal/resources/placeholder-user-resource.ts on lines 40..42
frontend/src/app/features/hal/resources/schema-resource.ts on lines 33..35
frontend/src/app/features/hal/resources/status-resource.ts on lines 41..43
frontend/src/app/features/hal/resources/type-resource.ts on lines 35..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

@Component({
  selector: 'op-wp-graph-configuration-filters-tab',
  templateUrl: './filters-tab.component.html',
  hostDirectives: [WorkPackageIsolatedQuerySpaceDirective], // TODO replace
})
Severity: Minor
Found in frontend/src/app/shared/components/work-package-graphs/configuration-modal/tabs/filters-tab.component.ts and 1 other location - About 40 mins to fix
frontend/src/app/shared/components/work-package-graphs/configuration-modal/tabs/settings-tab.component.ts on lines 7..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        identifier: 'work_packages_created',
        component: WidgetWpTableQuerySpaceComponent,
        title: i18n.t('js.grid.widgets.work_packages_created.title'),
        properties: {
Severity: Major
Found in frontend/src/app/shared/components/grids/openproject-grids.module.ts and 3 other locations - About 40 mins to fix
frontend/src/app/shared/components/grids/openproject-grids.module.ts on lines 206..214
frontend/src/app/shared/components/grids/openproject-grids.module.ts on lines 215..223
frontend/src/app/shared/components/grids/openproject-grids.module.ts on lines 233..241

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      } else if (selectedOperator === this.betweenDatesOperator) {
        valueContainer.classList.add('between-dates');
        valueContainer.classList.remove('days');
        valueContainer.classList.remove('on-date');
      }
Severity: Major
Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts and 2 other locations - About 40 mins to fix
frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 259..271
frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 263..271

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export interface IInAppNotificationHalResourceLinks extends IHalResourceLinks {
  actor:IHalResourceLink;
  project:IHalResourceLink;
  resource:IHalResourceLink;
  activity:IHalResourceLink;
Severity: Minor
Found in frontend/src/app/core/state/in-app-notifications/in-app-notification.model.ts and 1 other location - About 40 mins to fix
frontend/src/app/core/state/principals/user.model.ts on lines 4..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export class ViewsStore extends EntityStore<ViewsState> {
  constructor() {
    super(createInitialResourceState());
  }
}
Severity: Major
Found in frontend/src/app/core/state/views/views.store.ts and 16 other locations - About 40 mins to fix
frontend/src/app/core/state/attachments/attachments.store.ts on lines 36..40
frontend/src/app/core/state/capabilities/capabilities.store.ts on lines 9..13
frontend/src/app/core/state/days/day.store.ts on lines 15..19
frontend/src/app/core/state/days/weekday.store.ts on lines 15..19
frontend/src/app/core/state/file-links/file-links.store.ts on lines 36..40
frontend/src/app/core/state/in-app-notifications/in-app-notifications.store.ts on lines 9..13
frontend/src/app/core/state/principals/principals.store.ts on lines 9..13
frontend/src/app/core/state/project-storages/project-storages.store.ts on lines 37..41
frontend/src/app/core/state/projects/projects.store.ts on lines 9..13
frontend/src/app/core/state/storages/storages.store.ts on lines 36..40
frontend/src/app/features/enterprise/enterprise-trial.store.ts on lines 17..21
frontend/src/app/features/in-app-notifications/bell/state/ian-bell.store.ts on lines 17..21
frontend/src/app/features/in-app-notifications/center/state/ian-center.store.ts on lines 44..48
frontend/src/app/features/user-preferences/state/user-preferences.store.ts on lines 58..62
frontend/src/app/features/work-packages/routing/wp-view-base/state/wp-single-view.store.ts on lines 19..23
modules/github_integration/frontend/module/state/github-pull-request.store.ts on lines 12..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export class GithubPullRequestsStore extends EntityStore<GithubPullRequestsState> {
  constructor() {
    super(createInitialResourceState());
  }
}
Severity: Major
Found in modules/github_integration/frontend/module/state/github-pull-request.store.ts and 16 other locations - About 40 mins to fix
frontend/src/app/core/state/attachments/attachments.store.ts on lines 36..40
frontend/src/app/core/state/capabilities/capabilities.store.ts on lines 9..13
frontend/src/app/core/state/days/day.store.ts on lines 15..19
frontend/src/app/core/state/days/weekday.store.ts on lines 15..19
frontend/src/app/core/state/file-links/file-links.store.ts on lines 36..40
frontend/src/app/core/state/in-app-notifications/in-app-notifications.store.ts on lines 9..13
frontend/src/app/core/state/principals/principals.store.ts on lines 9..13
frontend/src/app/core/state/project-storages/project-storages.store.ts on lines 37..41
frontend/src/app/core/state/projects/projects.store.ts on lines 9..13
frontend/src/app/core/state/storages/storages.store.ts on lines 36..40
frontend/src/app/core/state/views/views.store.ts on lines 9..13
frontend/src/app/features/enterprise/enterprise-trial.store.ts on lines 17..21
frontend/src/app/features/in-app-notifications/bell/state/ian-bell.store.ts on lines 17..21
frontend/src/app/features/in-app-notifications/center/state/ian-center.store.ts on lines 44..48
frontend/src/app/features/user-preferences/state/user-preferences.store.ts on lines 58..62
frontend/src/app/features/work-packages/routing/wp-view-base/state/wp-single-view.store.ts on lines 19..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  public setValues(change:QuerySharingChange):void {
    this.isStarred = change.isStarred;
    this.isPublic = change.isPublic;
  }
Severity: Major
Found in frontend/src/app/shared/components/modals/save-modal/save-query.modal.ts and 2 other locations - About 40 mins to fix
frontend/src/app/shared/components/modals/share-modal/query-sharing.modal.ts on lines 90..93
frontend/src/app/shared/components/modals/view-settings-modal/view-settings.modal.ts on lines 83..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const type2 = halResourceService.createHalResourceOfClass(
      TypeResource,
      { _type: 'Type', id: '2', _links: { self: { href: '/api/v3/types/2', name: 'Bug' } } },
    );
Severity: Minor
Found in frontend/src/app/features/work-packages/components/wp-edit-form/work-package-filter-values.spec.ts and 1 other location - About 40 mins to fix
frontend/src/app/features/work-packages/components/wp-edit-form/work-package-filter-values.spec.ts on lines 109..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const type1 = halResourceService.createHalResourceOfClass(
      TypeResource,
      { _type: 'Type', id: '1', _links: { self: { href: '/api/v3/types/1', name: 'Task' } } },
    );
Severity: Minor
Found in frontend/src/app/features/work-packages/components/wp-edit-form/work-package-filter-values.spec.ts and 1 other location - About 40 mins to fix
frontend/src/app/features/work-packages/components/wp-edit-form/work-package-filter-values.spec.ts on lines 113..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export interface IUserHalResourceLinks extends IHalResourceLinks {
  lock:IHalResourceLink;
  unlock:IHalResourceLink;
  delete:IHalResourceLink;
  showUser:IHalResourceLink;
Severity: Minor
Found in frontend/src/app/core/state/principals/user.model.ts and 1 other location - About 40 mins to fix
frontend/src/app/core/state/in-app-notifications/in-app-notification.model.ts on lines 9..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      if (this.daysOperators.includes(selectedOperator)) {
        valueContainer.classList.add('days');
        valueContainer.classList.remove('on-date');
        valueContainer.classList.remove('between-dates');
      } else if (selectedOperator === this.onDateOperator) {
Severity: Major
Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts and 2 other locations - About 40 mins to fix
frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 263..271
frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 267..271

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      } else if (selectedOperator === this.onDateOperator) {
        valueContainer.classList.add('on-date');
        valueContainer.classList.remove('days');
        valueContainer.classList.remove('between-dates');
      } else if (selectedOperator === this.betweenDatesOperator) {
Severity: Major
Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts and 2 other locations - About 40 mins to fix
frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 259..271
frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 267..271

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public get gridEndRow() {
    if (this.isRow) {
      return this.endRow * 2 - 2;
    }
    return this.endRow * 2 - 1;
Severity: Minor
Found in frontend/src/app/shared/components/grids/areas/grid-gap.ts and 1 other location - About 40 mins to fix
frontend/src/app/shared/components/grids/areas/grid-gap.ts on lines 33..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def build_header_cells_weeks(top, height, columns)
      build_header_cells_parts(columns, top, height,
                               ->(date) { [date.year, date.cweek] },
                               ->(date, week_tuple) { date.year == week_tuple[0] && date.cweek == week_tuple[1] },
                               ->(week_tuple) { "W#{week_tuple[1]}" })
Severity: Minor
Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb and 1 other location - About 40 mins to fix
app/models/work_package/pdf_export/gantt/gantt_builder.rb on lines 302..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def build_header_cells_quarters(top, height, columns)
      build_header_cells_parts(columns, top, height,
                               ->(date) { [date.year, date.quarter] },
                               ->(date, quarter_tuple) {
                                 date.year == quarter_tuple[0] && date.quarter == quarter_tuple[1]
Severity: Minor
Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb and 1 other location - About 40 mins to fix
app/models/work_package/pdf_export/gantt/gantt_builder.rb on lines 323..327

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module Views
    class ContractStrategy < ::BaseContract
      validate :manageable

      private
Severity: Minor
Found in modules/team_planner/app/contracts/team_planner/views/contract_strategy.rb and 1 other location - About 40 mins to fix
modules/calendar/app/contracts/calendar/views/contract_strategy.rb on lines 2..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module Views
    class ContractStrategy < ::BaseContract
      validate :manageable

      private
Severity: Minor
Found in modules/calendar/app/contracts/calendar/views/contract_strategy.rb and 1 other location - About 40 mins to fix
modules/team_planner/app/contracts/team_planner/views/contract_strategy.rb on lines 2..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language