Sign upLogin

oppia/oppia

View on GitHub
Star

Showing 7,178 of 10,782 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should warn user if skill is created', () => {
    expect(() => {
      _sampleTopic.addUncategorizedSkill('skill_2', 'Description 2');
    }).toThrowError('Given skillId is already an uncategorized skill.');
  });
Severity: Major
Found in core/templates/domain/topic/topic-object.model.spec.ts and 4 other locations - About 30 mins to fix
core/templates/domain/story/story-contents-object.model.spec.ts on lines 319..323
core/templates/domain/story/story-contents-object.model.spec.ts on lines 410..414
core/templates/domain/topic/topic-object.model.spec.ts on lines 672..676
core/templates/pages/exploration-editor-page/translation-tab/services/translation-tab-active-content-id.service.spec.ts on lines 52..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('should throw error when exploration is already present in the story', () => {
    expect(() => {
      _sampleStoryContents.setNodeExplorationId('node_1', 'exp_1');
    }).toThrowError('The given exploration already exists in the story.');
  });
Severity: Major
Found in core/templates/domain/story/story-contents-object.model.spec.ts and 4 other locations - About 30 mins to fix
core/templates/domain/story/story-contents-object.model.spec.ts on lines 410..414
core/templates/domain/topic/topic-object.model.spec.ts on lines 672..676
core/templates/domain/topic/topic-object.model.spec.ts on lines 678..682
core/templates/pages/exploration-editor-page/translation-tab/services/translation-tab-active-content-id.service.spec.ts on lines 52..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      spyOn(
        blogHomePageBackendApiService,
        'fetchBlogHomePageDataAsync'
      ).and.returnValue(
        Promise.reject({
Severity: Major
Found in core/templates/pages/blog-home-page/blog-home-page.component.spec.ts and 4 other locations - About 30 mins to fix
core/templates/pages/blog-author-profile-page/blog-author-profile-page.component.spec.ts on lines 316..324
core/templates/pages/blog-author-profile-page/blog-author-profile-page.component.spec.ts on lines 345..353
core/templates/pages/blog-home-page/blog-home-page.component.spec.ts on lines 785..793
core/templates/pages/blog-post-page/blog-post-page-root.component.spec.ts on lines 261..269

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if (!this._isValid(this.displayed) || !this.hasChanged()) {
      this.restoreFromMemento();
      return;
    }
Severity: Minor
Found in core/templates/components/state-editor/state-editor-properties-services/state-property.service.ts and 1 other location - About 30 mins to fix
core/templates/pages/exploration-editor-page/services/exploration-property.service.ts on lines 129..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

@Pipe({name: 'wrapTextWithEllipsis'})
class MockWrapTextWithEllipsisPipe {
  transform(input: string, characterCount: number): string {
    return '';
  }
Severity: Minor
Found in core/templates/components/state-editor/state-responses-editor/state-responses.component.spec.ts and 1 other location - About 30 mins to fix
core/templates/pages/exploration-editor-page/translation-tab/state-translation/state-translation.component.spec.ts on lines 98..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if (!this._isValid(this.displayed) || !this.hasChanged()) {
      this.restoreFromMemento();
      return;
    }
Severity: Minor
Found in core/templates/pages/exploration-editor-page/services/exploration-property.service.ts and 1 other location - About 30 mins to fix
core/templates/components/state-editor/state-editor-properties-services/state-property.service.ts on lines 103..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      this.http
        .get<LearnerGroupBackendDict>(learnerGroupUrl)
        .toPromise()
        .then(
          learnerGroupInfo => {
Severity: Major
Found in core/templates/domain/learner_group/learner-group-backend-api.service.ts and 3 other locations - About 30 mins to fix
core/templates/domain/learner_group/learner-group-backend-api.service.ts on lines 103..113
core/templates/pages/exploration-editor-page/services/entity-translation-backend-api.service.ts on lines 62..74
core/templates/services/playthrough-issues-backend-api.service.ts on lines 80..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    this.drawGraph(
      this.graphData.nodes,
      this.graphData.links,
      this.graphData.initStateId,
      this.graphData.finalStateIds
Severity: Minor
Found in core/templates/pages/classroom-admin-page/modals/topic-dependency-graph-viz-modal.component.ts and 1 other location - About 30 mins to fix
core/templates/pages/exploration-editor-page/editor-tab/graph-directives/state-graph-visualization.component.ts on lines 188..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    {
      commit_type: 'edit',
      commit_cmds: [
        {
          cmd: 'delete_state',
Severity: Major
Found in core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts and 3 other locations - About 30 mins to fix
core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts on lines 367..379
core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts on lines 841..853
core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts on lines 1209..1221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        quote: 'I18N_SPLASH_TESTIMONIAL_1',
        studentDetails: 'I18N_SPLASH_STUDENT_DETAILS_1',
        imageUrl: this.getImageSet('/splash/mira', 'png'),
        imageUrlWebp: this.getImageSet('/splash/mira', 'webp'),
Severity: Major
Found in core/templates/pages/splash-page/splash-page.component.ts and 3 other locations - About 30 mins to fix
core/templates/pages/splash-page/splash-page.component.ts on lines 137..143
core/templates/pages/splash-page/splash-page.component.ts on lines 144..150
core/templates/pages/splash-page/splash-page.component.ts on lines 151..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      this.http
        .put<LearnerGroupBackendDict>(learnerGroupUpdationUrl, putData)
        .toPromise()
        .then(
          response => {
Severity: Major
Found in core/templates/domain/learner_group/learner-group-backend-api.service.ts and 3 other locations - About 30 mins to fix
core/templates/domain/learner_group/learner-group-backend-api.service.ts on lines 152..162
core/templates/pages/exploration-editor-page/services/entity-translation-backend-api.service.ts on lines 62..74
core/templates/services/playthrough-issues-backend-api.service.ts on lines 80..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      this.httpClient
        .get<PlaythroughIssueBackendDict>(
          this.getFetchPlaythroughUrl(explorationId, playthroughId)
        )
        .toPromise()
Severity: Major
Found in core/templates/services/playthrough-issues-backend-api.service.ts and 3 other locations - About 30 mins to fix
core/templates/domain/learner_group/learner-group-backend-api.service.ts on lines 103..113
core/templates/domain/learner_group/learner-group-backend-api.service.ts on lines 152..162
core/templates/pages/exploration-editor-page/services/entity-translation-backend-api.service.ts on lines 62..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

@Pipe({name: 'wrapTextWithEllipsis'})
class MockWrapTextWithEllipsisPipe {
  transform(input: string, characterCount: number): string {
    return '';
  }
Severity: Minor
Found in core/templates/pages/exploration-editor-page/translation-tab/state-translation/state-translation.component.spec.ts and 1 other location - About 30 mins to fix
core/templates/components/state-editor/state-responses-editor/state-responses.component.spec.ts on lines 70..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      this.drawGraph(
        this.graphData.nodes,
        this.graphData.links,
        this.graphData.initStateId,
        this.graphData.finalStateIds
Severity: Minor
Found in core/templates/pages/exploration-editor-page/editor-tab/graph-directives/state-graph-visualization.component.ts and 1 other location - About 30 mins to fix
core/templates/pages/classroom-admin-page/modals/topic-dependency-graph-viz-modal.component.ts on lines 83..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    {
      commit_type: 'edit',
      commit_cmds: [
        {
          cmd: 'delete_state',
Severity: Major
Found in core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts and 3 other locations - About 30 mins to fix
core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts on lines 303..315
core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts on lines 367..379
core/templates/pages/exploration-editor-page/history-tab/services/compare-versions.service.spec.ts on lines 1209..1221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        expect(
          contributionAndReviewService.reviewExplorationSuggestion
        ).toHaveBeenCalledWith(
          '1',
          'suggestion_1',
Severity: Minor
Found in core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.spec.ts and 1 other location - About 30 mins to fix
core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.spec.ts on lines 539..550

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        quote: 'I18N_SPLASH_TESTIMONIAL_3',
        studentDetails: 'I18N_SPLASH_STUDENT_DETAILS_3',
        imageUrl: this.getImageSet('/splash/sama', 'png'),
        imageUrlWebp: this.getImageSet('/splash/sama', 'webp'),
Severity: Major
Found in core/templates/pages/splash-page/splash-page.component.ts and 3 other locations - About 30 mins to fix
core/templates/pages/splash-page/splash-page.component.ts on lines 130..136
core/templates/pages/splash-page/splash-page.component.ts on lines 137..143
core/templates/pages/splash-page/splash-page.component.ts on lines 151..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    let topicSkillIds = cloneDeep(
      this._uncategorizedSkillSummaries.map(
        (skillSummary: ShortSkillSummary) => {
          return skillSummary.getId();
        }
Severity: Minor
Found in core/templates/domain/topic/topic-object.model.ts and 1 other location - About 30 mins to fix
core/templates/domain/topic/topic-object.model.ts on lines 366..372

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        errorMessage => {
          this.alertsService.clearWarnings();
          this.alertsService.addWarning(`Invalid Suggestion: ${errorMessage}`);
        }
Severity: Minor
Found in core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.ts and 1 other location - About 30 mins to fix
core/templates/pages/contributor-dashboard-page/modal-templates/translation-suggestion-review-modal.component.ts on lines 589..594

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      {
        quote: 'I18N_SPLASH_TESTIMONIAL_2',
        studentDetails: 'I18N_SPLASH_STUDENT_DETAILS_2',
        imageUrl: this.getImageSet('/splash/Dheeraj', 'png'),
        imageUrlWebp: this.getImageSet('/splash/Dheeraj', 'webp'),
Severity: Major
Found in core/templates/pages/splash-page/splash-page.component.ts and 3 other locations - About 30 mins to fix
core/templates/pages/splash-page/splash-page.component.ts on lines 130..136
core/templates/pages/splash-page/splash-page.component.ts on lines 144..150
core/templates/pages/splash-page/splash-page.component.ts on lines 151..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language