Sign upLogin

orbotix/sphero.js

View on GitHub
Star
lib/devices/sphero.js

Summary

Maintainability
D
2 days
Test Coverage

Function sphero has 246 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function sphero(device) {
  // Sphero Virtual Device Address = 0x02
  var command = device.command.bind(device, 0x02);

  /**
Severity: Major
Found in lib/devices/sphero.js - About 1 day to fix

    File sphero.js has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    "use strict";

var utils = require("../utils"),
    commands = require("../commands/sphero");
    Severity: Minor
    Found in lib/devices/sphero.js - About 2 hrs to fix

      Function sphero has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function sphero(device) {
  // Sphero Virtual Device Address = 0x02
  var command = device.command.bind(device, 0x02);

  /**
      Severity: Minor
      Found in lib/devices/sphero.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        device.setPermOptionFlags = function(flags, callback) {
    flags = utils.intToHexArray(flags, 4);
    return command(commands.setOptionsFlag, flags, callback);
  };
      Severity: Major
      Found in lib/devices/sphero.js and 5 other locations - About 50 mins to fix
      lib/devices/sphero.js on lines 24..27
      lib/devices/sphero.js on lines 103..106
      lib/devices/sphero.js on lines 524..527
      lib/devices/sphero.js on lines 611..614
      lib/devices/sphero.js on lines 1326..1329

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        device.setMotionTimeout = function(time, callback) {
    time = utils.intToHexArray(time, 2);
    return command(commands.setMotionTimeout, time, callback);
  };
      Severity: Major
      Found in lib/devices/sphero.js and 5 other locations - About 50 mins to fix
      lib/devices/sphero.js on lines 24..27
      lib/devices/sphero.js on lines 103..106
      lib/devices/sphero.js on lines 545..548
      lib/devices/sphero.js on lines 611..614
      lib/devices/sphero.js on lines 1326..1329

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        device.setChassisId = function(chassisId, callback) {
    chassisId = utils.intToHexArray(chassisId, 2);
    return command(commands.getChassisId, chassisId, callback);
  };
      Severity: Major
      Found in lib/devices/sphero.js and 5 other locations - About 50 mins to fix
      lib/devices/sphero.js on lines 24..27
      lib/devices/sphero.js on lines 524..527
      lib/devices/sphero.js on lines 545..548
      lib/devices/sphero.js on lines 611..614
      lib/devices/sphero.js on lines 1326..1329

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        device.setHeading = function(heading, callback) {
    heading = utils.intToHexArray(heading, 2);
    return command(commands.setHeading, heading, callback);
  };
      Severity: Major
      Found in lib/devices/sphero.js and 5 other locations - About 50 mins to fix
      lib/devices/sphero.js on lines 103..106
      lib/devices/sphero.js on lines 524..527
      lib/devices/sphero.js on lines 545..548
      lib/devices/sphero.js on lines 611..614
      lib/devices/sphero.js on lines 1326..1329

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        device.setTempOptionFlags = function(flags, callback) {
    flags = utils.intToHexArray(flags, 4);
    return command(commands.setTempOptionFlags, flags, callback);
  };
      Severity: Major
      Found in lib/devices/sphero.js and 5 other locations - About 50 mins to fix
      lib/devices/sphero.js on lines 24..27
      lib/devices/sphero.js on lines 103..106
      lib/devices/sphero.js on lines 524..527
      lib/devices/sphero.js on lines 545..548
      lib/devices/sphero.js on lines 1326..1329

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        device.submitValueToInput = function(val, callback) {
    val = utils.intToHexArray(val, 4);
    return command(commands.answerInput, val, callback);
  };
      Severity: Major
      Found in lib/devices/sphero.js and 5 other locations - About 50 mins to fix
      lib/devices/sphero.js on lines 24..27
      lib/devices/sphero.js on lines 103..106
      lib/devices/sphero.js on lines 524..527
      lib/devices/sphero.js on lines 545..548
      lib/devices/sphero.js on lines 611..614

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        device.executeOrbBasicProgram = function(area, slMSB, slLSB, callback) {
    return command(
      commands.execOBProgram,
      utils.argsToHexArray(area, slMSB, slLSB),
      callback
      Severity: Minor
      Found in lib/devices/sphero.js and 1 other location - About 35 mins to fix
      lib/devices/sphero.js on lines 1183..1189

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        device.setMacroParam = function(index, val1, val2, callback) {
    return command(
      commands.setMacroParam,
      utils.argsToHexArray(index, val1, val2),
      callback
      Severity: Minor
      Found in lib/devices/sphero.js and 1 other location - About 35 mins to fix
      lib/devices/sphero.js on lines 1286..1292

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status