Sign upLogin

orionsbelt-battlegrounds/battle-engine

View on GitHub
Star

Showing 7 of 21 total issues

Consider simplifying this complex logical expression.
Open

    if( dst.x == src.x + 1 && dst.y == src.y + 1 ||
      dst.x == src.x - 1 && dst.y == src.y - 1 ||
      dst.x == src.x + 1 && dst.y == src.y - 1 ||
      dst.x == src.x - 1 && dst.y == src.y + 1 ) {
      return true;
Severity: Critical
Found in src/moves/movement/diagonalMovement.js - About 1 hr to fix

    Function allMovement has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    (function allMovement(module) {

  module.isValid = function(numberOfPlayers,dst) {
    if( numberOfPlayers == 2 ) {
      if( dst.y != 8 && dst.y != 7 ) {
    Severity: Minor
    Found in src/moves/movement/positioning.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function resolveUltimateCoordinate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    basePositionConverter.prototype.resolveUltimateCoordinate = function(coord){
  if( this.numberOfPlayers == 2 ) {
      if( coord.equals(this.coordinate0) )  {
        return this.coordinate9;
      }
    Severity: Minor
    Found in src/engine/positionConverters/basePositionConverter.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function diagonalMovement has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    (function diagonalMovement(module) {

  module.name = "diagonalMovement";

  module.isValid = function(src,dst,position) {
    Severity: Minor
    Found in src/moves/movement/diagonalMovement.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function allMovement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    (function allMovement(module) {

  module.name = "allMovement";

  module.isValid = function(src,dst,position) {
    Severity: Minor
    Found in src/moves/movement/allMovement.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return null;
    Severity: Major
    Found in src/engine/positionConverters/basePositionConverter.js - About 30 mins to fix

      Function normalMovement has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      (function normalMovement(module) {

  module.name = 'normalMovement';

  module.isValid = function(src,dst,position) {
      Severity: Minor
      Found in src/moves/movement/normalMovement.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language