Sign upLogin

owncloud/core

View on GitHub
Star
apps/files/js/files.js

Summary

Maintainability
C
1 day
Test Coverage

File files.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2014
 *
 * This file is licensed under the Affero General Public License version 3
 * or later.
Severity: Minor
Found in apps/files/js/files.js - About 3 hrs to fix

    Function displayStorageWarnings has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            displayStorageWarnings: function() {
            if (!OC.Notification.isHidden()) {
                return;
            }
    Severity: Minor
    Found in apps/files/js/files.js - About 1 hr to fix

      Function createDragShadow has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var createDragShadow = function(event) {
    // FIXME: inject file list instance somehow
    /* global FileList, Files */

    //select dragged file
      Severity: Minor
      Found in apps/files/js/files.js - About 1 hr to fix

        Function initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                initialize: function() {
            Files.bindKeyboardShortcuts(document, $);

            // TODO: move file list related code (upload) to OCA.Files.FileList
            $('#file_action_panel').attr('activeAction', false);
        Severity: Minor
        Found in apps/files/js/files.js - About 1 hr to fix

          Function lazyLoadPreview has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  lazyLoadPreview : function(path, mime, ready, width, height, etag) {
          Severity: Minor
          Found in apps/files/js/files.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (files.length === 0) {
            // single one selected without checkbox?
            files = _.map(ui.helper.find('tr'), function(el) {
                return FileList.elementToFile($(el));
            });
            Severity: Major
            Found in apps/files/js/files.js and 1 other location - About 1 hr to fix
            apps/files/js/filelist.js on lines 895..900

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    getAjaxUrl: function(action, params) {
            var q = '';
            if (params) {
                q = '?' + OC.buildQueryString(params);
            }
            Severity: Major
            Found in apps/files/js/files.js and 1 other location - About 1 hr to fix
            apps/files_trashbin/js/filelist.js on lines 111..117

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status