Sign upLogin

owncloud/core

View on GitHub
Star
apps/files/js/mainfileinfodetailview.js

Summary

Maintainability
C
1 day
Test Coverage

Function loadPreview has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        loadPreview: function(path, mime, etag, $iconDiv, $container, isImage) {
            var maxImageWidth  = $container.parent().width() + 50;  // 50px for negative margins
            var maxImageHeight = maxImageWidth / (16/9);
            var smallPreviewSize = 75;
Severity: Major
Found in apps/files/js/mainfileinfodetailview.js - About 2 hrs to fix

    Function render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            render: function() {
            if (this.model) {
                var isFavorite = (this.model.get('tags') || []).indexOf(OC.TAG_FAVORITE) >= 0;
                this.$el.html(this.template({
                    type: this.model.isImage()? 'image': '',
    Severity: Minor
    Found in apps/files/js/mainfileinfodetailview.js - About 1 hr to fix

      Function loadPreview has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              loadPreview: function(path, mime, etag, $iconDiv, $container, isImage) {
      Severity: Minor
      Found in apps/files/js/mainfileinfodetailview.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var TEMPLATE =
        '<div class="thumbnailContainer"><a href="#" class="thumbnail action-default"><div class="stretcher"/></a></div>' +
        '<div class="file-details-container">' +
        '<div class="fileName">' +
            '<h3 title="{{name}}" class="ellipsis">{{name}}</h3>' +
        Severity: Major
        Found in apps/files/js/mainfileinfodetailview.js and 1 other location - About 2 hrs to fix
        core/js/sharedialogview.js on lines 51..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

                template: function(data) {
            if (!this._template) {
                this._template = Handlebars.compile(TEMPLATE);
            }
            return this._template(data);
        Severity: Major
        Found in apps/files/js/mainfileinfodetailview.js and 8 other locations - About 55 mins to fix
        apps/files/js/detailsview.js on lines 120..125
        apps/files/js/locktabview.js on lines 92..98
        apps/files_sharing/js/sharetabview.js on lines 25..30
        apps/files_versions/js/versionstabview.js on lines 266..272
        apps/files_versions/js/versionstabview.js on lines 274..280
        apps/files_versions/js/versionstabview.js on lines 282..288
        core/js/systemtags/systemtagsinputfield.js on lines 62..67
        core/js/systemtags/systemtagslist.js on lines 41..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status