Sign upLogin

owncloud/core

View on GitHub
Star
apps/files/js/templates/detailsview.handlebars.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function 2 has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

},"2":function(container,depth0,helpers,partials,data) {
Severity: Minor
Found in apps/files/js/templates/detailsview.handlebars.js - About 35 mins to fix

    Function 1 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    templates['detailsview'] = template({"1":function(container,depth0,helpers,partials,data) {
    Severity: Minor
    Found in apps/files/js/templates/detailsview.handlebars.js - About 35 mins to fix

      Function main has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      },"compiler":[7,">= 4.0.0"],"main":function(container,depth0,helpers,partials,data) {
      Severity: Minor
      Found in apps/files/js/templates/detailsview.handlebars.js - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          return "    <li class=\"tabHeader\" data-tabid=\""
    + alias4(((helper = (helper = helpers.tabId || (depth0 != null ? depth0.tabId : depth0)) != null ? helper : alias2),(typeof helper === alias3 ? helper.call(alias1,{"name":"tabId","hash":{},"data":data}) : helper)))
        Severity: Major
        Found in apps/files/js/templates/detailsview.handlebars.js and 2 other locations - About 2 hrs to fix
        apps/files/js/templates/detailsview.handlebars.js on lines 12..15
        apps/files/js/templates/detailsview.handlebars.js on lines 12..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 87.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status