owncloud/core

Function attach has 169 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        attach: function(fileList) {
            // core sharing is disabled/not loaded
            if (!OC.Share) {
                return;
            }

File share.js has 332 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * Copyright (c) 2014
 *
 * This file is licensed under the Affero General Public License version 3
 * or later.

Function _handlePublicLinkQuickAction has 95 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _handlePublicLinkQuickAction: function(fileInfoModel, shareTab, shareConfig) {
            var self = this;
            var shareDialog = shareTab._dialog;
            var linkShareView;
            var initNewShareLinkView = true;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            fileList._getWebdavProperties = function() {
                var props = oldGetWebdavProperties.apply(this, arguments);
                props.push(OC.Files.Client.PROPERTY_OWNER_DISPLAY_NAME);
                props.push(OC.Files.Client.PROPERTY_SHARE_TYPES);
                return props;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                    data.shareTypes = _.chain(shareTypesProp).filter(function(xmlvalue) {
                        return (xmlvalue.namespaceURI === OC.Files.Client.NS_OWNCLOUD && xmlvalue.nodeName.split(':')[1] === 'share-type');
                    }).map(function(xmlvalue) {
                        return parseInt(xmlvalue.textContent || xmlvalue.text, 10);
                    }).value();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _.extend(OC.Files.Client, {
        PROPERTY_SHARE_TYPES:    '{' + OC.Files.Client.NS_OWNCLOUD + '}share-types',
        PROPERTY_OWNER_DISPLAY_NAME:    '{' + OC.Files.Client.NS_OWNCLOUD + '}owner-display-name'
    });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        if ((permissions & OC.PERMISSION_SHARE) !== 0) {
                            var $actionLink = $(self.renderPublicLinkAction());
                            context.$file.find('a.name>span.fileactions').append($actionLink);
                            return $actionLink;
                        }

• Read up
  Read up