Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_sharing/js/sharedfilelist.js

Summary

Maintainability
D
2 days
Test Coverage

File sharedfilelist.js has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2014 Vincent Petry <pvince81@owncloud.com>
 *
 * This file is licensed under the Affero General Public License version 3
 * or later.
Severity: Minor
Found in apps/files_sharing/js/sharedfilelist.js - About 5 hrs to fix

    Function _makeFilesFromShares has 97 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _makeFilesFromShares: function(data) {
            /* jshint camelcase: false */
            var self = this;
            var files = data;
    Severity: Major
    Found in apps/files_sharing/js/sharedfilelist.js - About 3 hrs to fix

      Function _createRow has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _createRow: function(fileData) {
            // TODO: hook earlier and render the whole row here
            var $tr = OCA.Files.FileList.prototype._createRow.apply(this, arguments);
            var td;
            var formatted;
      Severity: Major
      Found in apps/files_sharing/js/sharedfilelist.js - About 2 hrs to fix

        Function reload has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                reload: function() {
            this.showMask();
            if (this._reloadCall) {
                this._reloadCall.abort();
            }
        Severity: Minor
        Found in apps/files_sharing/js/sharedfilelist.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          td.append($('<span></span>').attr({
                        "class": "modified",
                        "title": formatted,
                        "style": 'color:rgb(' + modifiedColor + ',' + modifiedColor + ',' + modifiedColor + ')'
                    }).text(text)
          Severity: Major
          Found in apps/files_sharing/js/sharedfilelist.js and 1 other location - About 2 hrs to fix
          apps/files/js/filelist.js on lines 1309..1315

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status