Sign upLogin

owncloud/core

View on GitHub
Star
apps/files_versions/js/versionstabview.js

Summary

Maintainability
D
2 days
Test Coverage

File versionstabview.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2015
 *
 * This file is licensed under the Affero General Public License version 3
 * or later.
Severity: Minor
Found in apps/files_versions/js/versionstabview.js - About 3 hrs to fix

    Function _onClickRevertVersion has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _onClickRevertVersion: function(ev) {
            var self = this;
            var $target = $(ev.target);
            var fileInfoModel = this.versionsRoot.getFileInfo();
            var revision;
    Severity: Major
    Found in apps/files_versions/js/versionstabview.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          var TEMPLATE_CURRENT =
        '<li data-revision="{{versionId}}" class="current-version">' +
        '<div>' +
        '<div class="preview-container">' +
        '<img class="preview" src="{{previewUrl}}"/>' +
      Severity: Major
      Found in apps/files_versions/js/versionstabview.js and 1 other location - About 3 hrs to fix
      apps/files_versions/js/versionstabview.js on lines 56..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          var TEMPLATE_VERSION =
        '<li data-revision="{{versionId}}">' +
        '<div>' +
        '<div class="preview-container">' +
        '<img class="preview" src="{{previewUrl}}"/>' +
      Severity: Major
      Found in apps/files_versions/js/versionstabview.js and 1 other location - About 3 hrs to fix
      apps/files_versions/js/versionstabview.js on lines 27..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              _onAddVersionsRootModel: function(model) {
            // add current version (versions root) as first item in the list
            var $el = $(this.currentTemplate(this._formatCurrent(model)));
            this.$versionsContainer.prepend($el);
            $el.find('.has-tooltip').tooltip();
      Severity: Major
      Found in apps/files_versions/js/versionstabview.js and 1 other location - About 1 hr to fix
      apps/files_versions/js/versionstabview.js on lines 252..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              _onAddVersionModel: function(model) {
            // add version to the list (collection child)
            var $el = $(this.versionTemplate(this._formatVersion(model)));
            this.$versionsContainer.append($el);
            $el.find('.has-tooltip').tooltip();
      Severity: Major
      Found in apps/files_versions/js/versionstabview.js and 1 other location - About 1 hr to fix
      apps/files_versions/js/versionstabview.js on lines 259..264

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              currentTemplate: function(data) {
            if (!this._currentTemplate) {
                this._currentTemplate = Handlebars.compile(TEMPLATE_CURRENT);
            }
      Severity: Major
      Found in apps/files_versions/js/versionstabview.js and 8 other locations - About 55 mins to fix
      apps/files/js/detailsview.js on lines 120..125
      apps/files/js/locktabview.js on lines 92..98
      apps/files/js/mainfileinfodetailview.js on lines 66..71
      apps/files_sharing/js/sharetabview.js on lines 25..30
      apps/files_versions/js/versionstabview.js on lines 266..272
      apps/files_versions/js/versionstabview.js on lines 274..280
      core/js/systemtags/systemtagsinputfield.js on lines 62..67
      core/js/systemtags/systemtagslist.js on lines 41..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              template: function(data) {
            if (!this._template) {
                this._template = Handlebars.compile(TEMPLATE);
            }
      Severity: Major
      Found in apps/files_versions/js/versionstabview.js and 8 other locations - About 55 mins to fix
      apps/files/js/detailsview.js on lines 120..125
      apps/files/js/locktabview.js on lines 92..98
      apps/files/js/mainfileinfodetailview.js on lines 66..71
      apps/files_sharing/js/sharetabview.js on lines 25..30
      apps/files_versions/js/versionstabview.js on lines 274..280
      apps/files_versions/js/versionstabview.js on lines 282..288
      core/js/systemtags/systemtagsinputfield.js on lines 62..67
      core/js/systemtags/systemtagslist.js on lines 41..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              versionTemplate: function(data) {
            if (!this._versionTemplate) {
                this._versionTemplate = Handlebars.compile(TEMPLATE_VERSION);
            }
      Severity: Major
      Found in apps/files_versions/js/versionstabview.js and 8 other locations - About 55 mins to fix
      apps/files/js/detailsview.js on lines 120..125
      apps/files/js/locktabview.js on lines 92..98
      apps/files/js/mainfileinfodetailview.js on lines 66..71
      apps/files_sharing/js/sharetabview.js on lines 25..30
      apps/files_versions/js/versionstabview.js on lines 266..272
      apps/files_versions/js/versionstabview.js on lines 282..288
      core/js/systemtags/systemtagsinputfield.js on lines 62..67
      core/js/systemtags/systemtagslist.js on lines 41..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              _toggleLoading: function(state) {
            this._loading = state;
            this.$el.find('.loading').toggleClass('hidden', !state);
        },
      Severity: Minor
      Found in apps/files_versions/js/versionstabview.js and 1 other location - About 40 mins to fix
      apps/comments/js/commentstabview.js on lines 188..191

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status