Sign upLogin

owncloud/core

View on GitHub
Star
apps/systemtags/js/systemtagsfilelist.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function _initFilterField has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            _initFilterField: function ($container) {
                this.$filterField = $('<input type="hidden" name="tags"/>');
                $container.append(this.$filterField);
                this.$filterField.select2({
                    placeholder: t('systemtags', 'Select tags to filter by'),
Severity: Minor
Found in apps/systemtags/js/systemtagsfilelist.js - About 1 hr to fix

    Function reload has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                reload: function () {
                if (!this._systemTagIds.length) {
                    // don't reload
                    this.updateEmptyContent();
                    this.setFiles([]);
    Severity: Minor
    Found in apps/systemtags/js/systemtagsfilelist.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          } else {
                        // tags selected but no results
                        this.$el.find('#emptycontent').html('<div class="icon-systemtags"></div>' +
                            '<h2>' + t('systemtags', 'No files found for the selected tags') + '</h2>');
                    }
      Severity: Minor
      Found in apps/systemtags/js/systemtagsfilelist.js and 1 other location - About 30 mins to fix
      apps/systemtags/js/systemtagsfilelist.js on lines 175..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (!this._systemTagIds.length) {
                        // no tags selected
                        this.$el.find('#emptycontent').html('<div class="icon-systemtags"></div>' +
                            '<h2>' + t('systemtags', 'Please select tags to filter by') + '</h2>');
                    } else {
      Severity: Minor
      Found in apps/systemtags/js/systemtagsfilelist.js and 1 other location - About 30 mins to fix
      apps/systemtags/js/systemtagsfilelist.js on lines 179..183

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status