owncloud/core

File sharedialogview.js has 526 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * Copyright (c) 2015
 *
 * This file is licensed under the Affero General Public License version 3
 * or later.

Function autocompleteHandler has 145 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        autocompleteHandler: function (search, response) {
            var view = this;
            var $loading = this.$el.find('.shareWithLoading');
            var trimmedSearch = search.term.trim();
            $loading.removeClass('hidden');

Function _getUsersForBatchAction has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _getUsersForBatchAction: function(search) {
            var view = this;
            var foundUsers = [];
            var notFound = [];
            var promises = [];

Function autocompleteRenderItem has 49 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        autocompleteRenderItem: function(ul, item) {
            var text = item.label;
            var showIcon = false;
            var iconClass = "";
            var typeInfo = t('core', 'User');

Function initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        initialize: function(options) {
            var view = this;

            this.model.on('fetchError', function() {
                OC.Notification.showTemporary(t('core', 'Share details could not be loaded for this item.'));

Function render has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        render: function() {
            var baseTemplate = this._getTemplate('base', TEMPLATE_BASE);

            this.$el.html(baseTemplate({
                cid: this.cid,

Avoid deeply nested control flow statements.

Open

                            } else if (share.share_type === OC.Share.SHARE_TYPE_REMOTE) {
                                remotesLength = remotes.length;
                                for (j = 0; j < remotesLength; j++) {
                                    if (remotes[j].value.shareWith === share.share_with) {
                                        remotes.splice(j, 1);

Avoid deeply nested control flow statements.

Open

                                    if (users[j].value.shareWith === share.share_with) {
                                        users.splice(j, 1);
                                        break;
                                    }

Avoid deeply nested control flow statements.

Open

                                        if (res.found[i].shareWith === OC.currentUser) {
                                            res.found.splice(i, 1);
                                            continue;
                                        }

Avoid deeply nested control flow statements.

Open

                                for (j = 0; j < groupsLength; j++) {
                                    if (groups[j].value.shareWith === share.share_with) {
                                        groups.splice(j, 1);
                                        break;
                                    }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    var TEMPLATE_AUTOCOMPLETE_ITEM =
        '<li class="{{shareTypeClass}}">' +
            '<a>' +
                '<div class="share-autocomplete-item">' +
                    '{{#if showAvatar}}' +

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                            } else if (share.share_type === OC.Share.SHARE_TYPE_REMOTE) {
                                remotesLength = remotes.length;
                                for (j = 0; j < remotesLength; j++) {
                                    if (remotes[j].value.shareWith === share.share_with) {
                                        remotes.splice(j, 1);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                            if (share.share_type === OC.Share.SHARE_TYPE_USER) {
                                usersLength = users.length;
                                for (j = 0; j < usersLength; j++) {
                                    if (users[j].value.shareWith === share.share_with) {
                                        users.splice(j, 1);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

                            } else if (share.share_type === OC.Share.SHARE_TYPE_GROUP) {
                                groupsLength = groups.length;
                                for (j = 0; j < groupsLength; j++) {
                                    if (groups[j].value.shareWith === share.share_with) {
                                        groups.splice(j, 1);

• Read up
  Read up