owncloud/core

Method sendMail has 11 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $toaddress,
        $toname,
        $subject,
        $mailtext,
        $fromaddress,

Method getItems has 11 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $itemType,
        $item = null,
        $shareType = null,
        $shareWith = null,
        $uidOwner = null,

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    public function __construct(
        $AppName,
        IRequest $request,
        IConfig $config,
        IClientService $clientService,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    public function __construct(
        $appName,
        IRequest $request,
        IAppManager $appManager,
        IRootFolder $rootFolder,

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    public function __construct(
        $appName,
        IRequest $request,
        IUserSession $userSession,
        TagService $tagService,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        try {
            $message = $this->mailer->createMessage();
            $message->setTo([$email => $name]);
            $message->setSubject($this->l10n->t('%s password reset', [$this->defaults->getName()]));
            $message->setPlainBody($msgAlt);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    public function __construct(
        $appName,
        IRequest $request,
        ISecureRandom $secureRandom,
        IJobList $jobList,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (!$exists) {
            \OC_Hook::emit(Filesystem::CLASSNAME, Filesystem::signal_create, [
                Filesystem::signal_param_path => $this->getHookPath($path),
                Filesystem::signal_param_run => &$run,
            ]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $query->update('share')
            ->set('uid_owner', $query->createParameter('uid_owner'))
            ->where(
                $query->expr()->andX(
                    $query->expr()->eq('id', $query->createParameter('shareid')),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            try {
                $message = $this->mailer->createMessage();
                $message->setTo([$email => $name]);
                $message->setSubject($this->l10n->t('%s password changed successfully', [$this->defaults->getName()]));
                $message->setPlainBody($msgAlt);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $query->update('share')
            ->set('uid_initiator', $query->createParameter('uid_initiator'))
            ->where(
                $query->expr()->andX(
                    $query->expr()->eq('id', $query->createParameter('shareid')),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (!$distributedCacheClass::isAvailable()) {
            if (\OC::$CLI && !\defined('PHPUNIT_RUN')) {
                // CLI should not hard-fail on broken memcache
                $this->logger->debug($missingCacheMessage, [
                    'class' => $distributedCacheClass,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        } else {
            \OC_Hook::emit(Filesystem::CLASSNAME, Filesystem::signal_update, [
                Filesystem::signal_param_path => $this->getHookPath($path),
                Filesystem::signal_param_run => &$run,
            ]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (!$localCacheClass::isAvailable()) {
            if (\OC::$CLI && !\defined('PHPUNIT_RUN')) {
                // CLI should not hard-fail on broken memcache
                $this->logger->debug($missingCacheMessage, [
                    'class' => $localCacheClass,

• Read up
  Read up

Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        render: function() {
            var self = this;
            if (this._dialog) {
                // remove/destroy older instance
                this._dialog.model.off();

Function attach has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        attach: function (view) {
            var that = this;
            var baseRenderCall = view.render;

            var shareCollectionModel = view.model.getLinkSharesCollection();

Function reloadCallback has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        reloadCallback: function(result) {
            delete this._reloadCall;
            this.hideMask();

            if (!result || result.status === 'error') {

Function showAddExternalDialog has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    OCA.Sharing.showAddExternalDialog = function (share, passwordProtected, callback) {
        var remote = share.remote;
        var owner = share.ownerDisplayName || share.owner;
        var name = share.name;
        var remoteClean = (remote.substr(0, 8) === 'https://') ? remote.substr(8) : remote.substr(7);

Function _saveToOwnCloud has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _saveToOwnCloud: function (remote, token, owner, ownerDisplayName, name, isProtected) {
        var that = this;

        var toggleLoading = function () {
            var isLoading = !that.$saveToOcButton.find('#save-to-oc-button-loading').hasClass('hidden');

Function actionHandler has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

                actionHandler: function(fileName, context) {
                    var $actionEl = context.$file.find('.action-favorite');
                    var $file = context.$file;
                    var fileInfo = context.fileList.files[$file.index()];
                    var dir = context.dir || context.fileList.getCurrentDirectory();