owncloud/core

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            case IMAGETYPE_PNG:
                if (\imagetypes() & IMG_PNG) {
                    $this->resource = \imagecreatefrompng($imagePath);
                    // Preserve transparency
                    \imagealphablending($this->resource, true);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (!$publicShare) {
                $query = \OC_DB::prepare(
                    '
                    SELECT `share_with`
                    FROM `*PREFIX*share`

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (!$remoteShare) {
                $query = \OC_DB::prepare(
                    '
                    SELECT `share_with`
                    FROM `*PREFIX*share`

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            case IMAGETYPE_GIF:
                if (\imagetypes() & IMG_GIF) {
                    $this->resource = \imagecreatefromgif($imagePath);
                    // Preserve transparency
                    \imagealphablending($this->resource, true);

• Read up
  Read up

Function share has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

    share:function(itemType, itemSource, shareType, shareWith, permissions, itemSourceName, expirationDate, callback, errorCallback) {

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        string $appName,
        IRequest $request,
        MailNotifications $mailNotifications,
        IUserSession $userSession,
        IUserManager $userManager,

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $appName,
        IRequest $request,
        OcmMiddleware $ocmMiddleware,
        IURLGenerator $urlGenerator,
        IUserManager $userManager,

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $appName,
        IRequest $request,
        IJobList $jobList,
        ISecureRandom $secureRandom,
        IConfig $config,

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $appName,
        IRequest $request,
        IURLGenerator $urlGenerator,
        IL10N $l10n,
        IConfig $config,

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        IRequest $request,
        ControllerMethodReflector $reflector,
        INavigationManager $navigationManager,
        IURLGenerator $urlGenerator,
        ILogger $logger,

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        IUserManager $manager,
        ISession $session,
        ITimeFactory $timeFactory,
        IProvider $tokenProvider,
        IConfig $config,

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $appName,
        IRequest $request,
        IUserManager $userManager,
        IConfig $config,
        ISession $session,

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $appName,
        IRequest $request,
        IAvatarManager $avatarManager,
        File $cache,
        IL10N $l10n,

Function _addAppPassword has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _addAppPassword: function() {
            var _this = this;

            var deviceName = this._tokenName.val();
            if (!deviceName) {

Function getDefaultFileActions has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

         getDefaultFileActions: function(mime, type, permissions) {
            var mimePart;
            if (mime) {
                mimePart = mime.substr(0, mime.indexOf('/'));
            }

Function uploads has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        selection.uploads = _.filter(selection.uploads, function(upload) {
            var file = upload.getFile();
            if (file.relativePath) {
                // can't check in subfolder contents, let backend handle this
                return true;

Function _legacyFillCurrentShares has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _legacyFillCurrentShares: function(shares) {
            var fileId = this.fileInfoModel.get('id');
            if (!shares || !shares.length) {
                delete OC.Share.statuses[fileId];
                OC.Share.currentShares = {};

Function _handleAddShareAttributes has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        _handleAddShareAttributes: function(properties, options) {
            var shareAttributesV1 = [];
            var filteredRegisteredAttributes = this._filterRegisteredAttributes(properties.permissions);
            _.map(filteredRegisteredAttributes, function (filteredRegisteredAttribute) {
                var isCompatible = true;

Function renderFileResult has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            this.renderFileResult = function($row, result) {
                if (inFileList($row, result)) {
                    return null;
                }
                hideNoFilterResults();

Function getFileInfo has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getFileInfo: function(path, options) {
            if (!path) {
                path = '';
            }
            options = options || {};