owncloud/core

View on GitHub

Showing 4,504 of 4,504 total issues

Function emitPreHooks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function emitPreHooks($exists, $path = null) {
        if ($path === null) {
            $path = $this->path;
        }
        $hookPath = Filesystem::getView()->getRelativePath($this->fileView->getAbsolutePath($path));
Severity: Minor
Found in apps/dav/lib/Connector/Sabre/File.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLock has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function getLock(RequestInterface $request) {
        // we can't listen on 'beforeMethod:PUT' due to order of operations with setting up the tree
        // so instead we limit ourselves to the PUT method manually
        if ($request->getMethod() !== 'PUT' || \OC_FileChunking::isWebdavChunk()) {
            return;
Severity: Minor
Found in apps/dav/lib/Connector/Sabre/LockPlugin.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stream_read has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function stream_read($count) {
        $node = null;
        $lastNode = null;
        do {
            if ($this->currentStream === null) {
Severity: Minor
Found in apps/dav/lib/Upload/AssemblyStream.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getPhoto has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function getPhoto(Card $node) {
        // TODO: this is kind of expensive - load carddav data from database and parse it
        //       we might want to build up a cache one day
        try {
            $vObject = $this->readCard($node->get());
Severity: Minor
Found in apps/dav/lib/CardDAV/ImageExportPlugin.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output): int {
        $authBackends = $this->backendService->getAuthMechanisms();
        $storageBackends = $this->backendService->getBackends();

        $data = [
Severity: Minor
Found in apps/files_external/lib/Command/Backends.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function validate(IStorageConfig $storage) {
        $mountPoint = $storage->getMountPoint();
        if ($mountPoint === '' || $mountPoint === '/') {
            return new DataResponse(
                [
Severity: Minor
Found in apps/files_external/lib/Controller/StoragesController.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method searchEx has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function searchEx($addressBookId, $pattern, $searchProperties, $options, $limit = 100, $offset = 0) {
Severity: Minor
Found in apps/dav/lib/CardDAV/CardDavBackend.php - About 45 mins to fix

    Function delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function delete($path) {
            $moveSource = $this->moveSource;
            $this->moveSource = null;
    
            if ($moveSource === $path) {
    Severity: Minor
    Found in apps/dav/lib/DAV/FileCustomPropertiesBackend.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loadChildrenProperties has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function loadChildrenProperties(INode $node, $requestedProperties) {
            // note: pre-fetching only supported for depth <= 1
            if (!($node instanceof Directory)) {
                return;
            }
    Severity: Minor
    Found in apps/dav/lib/DAV/FileCustomPropertiesBackend.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $AppName,
            IRequest $request,
            IL10N $l10n,
            IUserGlobalStoragesService $userGlobalStoragesService,
            IUserSession $userSession,
    Severity: Minor
    Found in apps/files_external/lib/Controller/UserGlobalStoragesController.php - About 45 mins to fix

      Function updateTags has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function updateTags($fileId, $tags) {
              $tagger = $this->getTagger();
              $currentTags = $this->getTags($fileId);
      
              $newTags = \array_diff($tags, $currentTags);
      Severity: Minor
      Found in apps/dav/lib/Connector/Sabre/TagsPlugin.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method scanFiles has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function scanFiles($user, $path, $verbose, OutputInterface $output, $backgroundScan = false, $shouldRepair = false) {
      Severity: Minor
      Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (self::metaEnabled()) {
                                    $versionFileInfo = $view->getFileInfo("$dir/$entryName");
                                    if ($versionFileInfo) {
                                        $versionMetadata = self::$metaData->getVersionMetadata($versionFileInfo);
        
        
        Severity: Major
        Found in apps/files_versions/lib/Storage.php - About 45 mins to fix

          Method userScan has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              protected function userScan($users, $inputPath, $shouldRepairStoragesIndividually, $input, $output, $verbose) {
          Severity: Minor
          Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

            Function dependencyMessage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function dependencyMessage($backends) {
                    $l = \OC::$server->getL10N('files_external');
                    $message = '';
                    $dependencyGroups = [];
            
            
            Severity: Minor
            Found in apps/files_external/lib/config.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function touch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function touch($path, $mtime = null) {
                    $file = $this->getDriveFile($path);
                    $toUpdate = new DriveFile();
                    $result = false;
                    if ($file) {
            Severity: Minor
            Found in apps/files_external/lib/Lib/Storage/Google.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function delete($path) {
                    $deletedFile = self::$deletedFiles[$path];
                    $uid = $deletedFile['uid'];
                    $filename = $deletedFile['filename'];
            
            
            Severity: Minor
            Found in apps/files_versions/lib/Storage.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function scanFiles has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function scanFiles($user, $path, $verbose, OutputInterface $output, $backgroundScan = false, $shouldRepair = false) {
                    $connection = $this->reconnectToDatabase($output);
                    $scanner = new \OC\Files\Utils\Scanner($user, $connection, \OC::$server->getLogger());
                    if ($shouldRepair) {
                        $scanner->listen('\OC\Files\Utils\Scanner', 'beforeScanStorage', function ($storage) use ($output, $connection) {
            Severity: Minor
            Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    IUserManager $userManager,
                    IManager $shareManager,
                    IMountManager $mountManager,
                    IRootFolder $rootFolder,
                    Manager $encryptionManager,
            Severity: Minor
            Found in apps/files/lib/Command/TransferOwnership.php - About 45 mins to fix

              Function processUserChunks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
                      # no messaging level option means: no full printout but statistics
                      # $quiet   means no print at all
                      # $verbose means full printout including statistics
                      # -q    -v    full    stat
              Severity: Minor
              Found in apps/files/lib/Command/Scan.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language