owncloud/core

View on GitHub

Showing 4,504 of 4,504 total issues

Google has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

class Google extends \OCP\Files\Storage\StorageAdapter {
    private $client;
    private $id;
    private $root;
    private $service;
Severity: Minor
Found in apps/files_external/lib/Lib/Storage/Google.php - About 3 hrs to fix

    File groups.js has 319 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * Copyright (c) 2014, Raghu Nayyar <beingminimal@gmail.com>
     * Copyright (c) 2014, Arthur Schiwon <blizzz@owncloud.com>
     * This file is licensed under the Affero General Public License version 3 or later.
     * See the COPYING-README file.
    Severity: Minor
    Found in settings/js/users/groups.js - About 3 hrs to fix

      File pt_PT.js has 319 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      OC.L10N.register(
          "core",
          {
          "Please select a file." : "Por favor, selecione um ficheiro.",
          "File is too big" : "O ficheiro é demasiado grande",
      Severity: Minor
      Found in core/l10n/pt_PT.js - About 3 hrs to fix

        File Activity.php has 319 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /**
         * @author Björn Schießle <bjoern@schiessle.org>
         * @author Joas Schilling <coding@schilljs.com>
         * @author Morris Jobke <hey@morrisjobke.de>
        Severity: Minor
        Found in apps/files_sharing/lib/Activity.php - About 3 hrs to fix

          File Scanner.php has 319 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /**
           * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
           * @author Björn Schießle <bjoern@schiessle.org>
           * @author Daniel Jagszent <daniel@jagszent.de>
          Severity: Minor
          Found in lib/private/Files/Cache/Scanner.php - About 3 hrs to fix

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "lib",
                {
                "Unknown filetype" : "Typo de file incognite",
                "Invalid image" : "Imagine invalide",
            Severity: Major
            Found in lib/l10n/ia.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "federatedfilesharing",
                {
                "Loading..." : "Memuat...",
                "Invalid Federated Cloud ID" : "Federated Cloud ID tidak sah",
            Severity: Major
            Found in apps/federatedfilesharing/l10n/id.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "files_external",
                {
                "External storage" : "බාහිර ආචයනය",
                "Google Drive App Configuration" : "ගූගල් ඩ්‍රයිව් යෙදුමේ වින්‍යාසය",
            Severity: Major
            Found in apps/files_external/l10n/si.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "comments",
                {
                "Type in a new comment..." : "Tik ’n nuwe kommentaar in…",
                "Delete comment" : "Skrap kommentaar",
            Severity: Major
            Found in apps/comments/l10n/af_ZA.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "files",
                {
                "Delete" : "Устгах",
                "Files" : "Файлууд",
            Severity: Major
            Found in apps/files/l10n/mn.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "settings",
                {
                "Share" : "هاوبەشی کردن",
                "Invalid request" : "داواکارى نادروستە",
            Severity: Major
            Found in settings/l10n/ku_IQ.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "comments",
                {
                "Type in a new comment..." : "Ierakstīt šeit jaunu komentāru...",
                "Delete comment" : "Dzēst komentāru",
            Severity: Major
            Found in apps/comments/l10n/lv.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "core",
                {
                "Sunday" : "Ням",
                "Monday" : "Даваа",
            Severity: Major
            Found in core/l10n/mn.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "comments",
                {
                "Type in a new comment..." : "Scrie un comentariu nou...",
                "Delete comment" : "Șterge comentariul",
            Severity: Major
            Found in apps/comments/l10n/ro.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "files_external",
                {
                "External storage" : "ឃ្លាំងផ្ទុក​ខាងក្រៅ",
                "Personal" : "ផ្ទាល់​ខ្លួន",
            Severity: Major
            Found in apps/files_external/l10n/km.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "settings",
                {
                "Delete" : "ਹਟਾਓ",
                "Share" : "ਸਾਂਝਾ ਕਰੋ",
            Severity: Major
            Found in settings/l10n/pa.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/es_CL.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

            OC.L10N.register(
                "files",
                {
                "Unknown error" : "Error desconocido",
                "Download" : "Descargar",
            Severity: Major
            Found in apps/files/l10n/es_CL.js and 11 other locations - About 3 hrs to fix
            apps/comments/l10n/af_ZA.js on lines 1..23
            apps/comments/l10n/lv.js on lines 1..23
            apps/comments/l10n/ro.js on lines 1..23
            apps/federatedfilesharing/l10n/id.js on lines 1..23
            apps/files/l10n/mn.js on lines 1..23
            apps/files_external/l10n/km.js on lines 1..23
            apps/files_external/l10n/si.js on lines 1..23
            core/l10n/mn.js on lines 1..23
            lib/l10n/ia.js on lines 1..23
            settings/l10n/ku_IQ.js on lines 1..23
            settings/l10n/pa.js on lines 1..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (url) {
                            var width = 600;
                            var height = 400;
                            var left = (screen.width/2)-(width/2);
                            var top = (screen.height/2)-(height/2);
            Severity: Major
            Found in core/js/sharedialoglinksocialview.js and 1 other location - About 3 hrs to fix
            apps/federatedfilesharing/js/settings-personal-general.js on lines 5..12

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (url) {
                        var width = 600;
                        var height = 400;
                        var left = (screen.width/2)-(width/2);
                        var top = (screen.height/2)-(height/2);
            Severity: Major
            Found in apps/federatedfilesharing/js/settings-personal-general.js and 1 other location - About 3 hrs to fix
            core/js/sharedialoglinksocialview.js on lines 68..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method getUsers has 91 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function getUsers($search) {
                    $this->result['users'] = $this->result['exact']['users'] = $users = [];
            
                    if (\strlen(\trim($search)) === 0 && $this->userSearch->getSearchMinLength() > 0) {
                        $this->result['users'] = [];
            Severity: Major
            Found in apps/files_sharing/lib/Controller/ShareesController.php - About 3 hrs to fix
              Severity
              Category
              Status
              Source
              Language