Sign upLogin

owncloud/core

View on GitHub
Star

Showing 3,235 of 4,504 total issues

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $AppName,
        IRequest $request,
        IL10N $l10n,
        IUserStoragesService $userStoragesService,
        IUserSession $userSession,
Severity: Major
Found in apps/files_external/lib/Controller/UserStoragesController.php - About 50 mins to fix

    Method syncRemoteAddressBook has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function syncRemoteAddressBook($url, $userName, $sharedSecret, $syncToken, $targetBookId, $targetPrincipal, $targetProperties) {
    Severity: Major
    Found in apps/dav/lib/CardDAV/SyncService.php - About 50 mins to fix

      Method update has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $id,
        $mountPoint,
        $backend,
        $authMechanism,
        $backendOptions,
      Severity: Major
      Found in apps/files_external/lib/Controller/UserStoragesController.php - About 50 mins to fix

        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $appName,
        IRequest $request,
        IUserSession $userSession,
        TagService $tagService,
        IPreview $previewManager,
        Severity: Major
        Found in apps/files/lib/Controller/ApiController.php - About 50 mins to fix

          Method setCookie has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function setCookie($name, $value, $expire, $path, $domain, $secure, $httpOnly);
          Severity: Major
          Found in lib/public/AppFramework/Http/IOutput.php - About 50 mins to fix

            Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $format,
        $statuscode,
        $message,
        $data=[],
        $itemscount='',
            Severity: Major
            Found in lib/public/AppFramework/Http/OCSResponse.php - About 50 mins to fix

              Method createMailBody has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $filename,
        $link,
        $expiration,
        $senderDisplayName,
        $personalNote = null,
              Severity: Major
              Found in lib/private/Share/MailNotifications.php - About 50 mins to fix

                Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        EnvironmentHelper $environmentHelper,
        FileAccessHelper $fileAccessHelper,
        AppLocator $appLocator,
        IConfig $config = null,
        ICacheFactory $cacheFactory,
                Severity: Major
                Found in lib/private/IntegrityCheck/Checker.php - About 50 mins to fix

                  Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          IUserStoragesService $storagesService,
        $storageId,
        $storage,
        $mountpoint,
        $arguments = null,
                  Severity: Major
                  Found in lib/private/Files/External/PersonalMount.php - About 50 mins to fix

                    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            IConfig $config,
        IDBConnection $connection,
        IUserManager $userManager,
        IAvatarManager $avatarManager,
        IRootFolder $rootFolder,
                    Severity: Major
                    Found in lib/private/Repair/MoveAvatarIntoSubFolder.php - About 50 mins to fix

                      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              IConfig $config,
        IDBConnection $connection,
        IUserManager $userManager,
        IAvatarManager $avatarManager,
        IRootFolder $rootFolder,
                      Severity: Major
                      Found in lib/private/Repair/MoveAvatarOutsideHome.php - About 50 mins to fix

                        Method generateTarget has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public static function generateTarget($itemType, $itemSource, $shareType, $shareWith, $uidOwner, $suggestedTarget = null, $groupParent = null) {
                        Severity: Major
                        Found in lib/private/Share/Helper.php - About 50 mins to fix

                          Method deleteOrphanEntries has 7 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              protected function deleteOrphanEntries(IOutput $output, $repairInfo, $deleteTable, $deleteId, $sourceTable, $sourceId, $sourceNullColumn) {
                          Severity: Major
                          Found in lib/private/Repair/CleanTags.php - About 50 mins to fix

                            Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    $user = '',
        $root = '/',
        Node $file = null,
        $maxX = 1,
        $maxY = 1,
                            Severity: Major
                            Found in lib/private/Preview.php - About 50 mins to fix

                              Method setCookie has 7 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function setCookie($name, $value, $expire, $path, $domain, $secure, $httpOnly) {
                              Severity: Major
                              Found in lib/private/AppFramework/Http/Output.php - About 50 mins to fix

                                Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        $appName,
        IRequest $request,
        IAppManager $appManager,
        IRootFolder $rootFolder,
        IURLGenerator $generator,
                                Severity: Major
                                Found in core/Controller/AppRegistryController.php - About 50 mins to fix

                                  Function _saveToOwnCloud has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      _saveToOwnCloud: function (remote, token, owner, ownerDisplayName, name, isProtected) {
                                  Severity: Minor
                                  Found in apps/files_sharing/js/public.js - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                                    if (OC.isUserAdmin()) {
                                    OC.redirect(OC.generateUrl('/settings/admin?sectionid=storage'));
                                }
                                else {
                                    OC.redirect(OC.generateUrl('/settings/personal?sectionid=storage'));
                                    Severity: Major
                                    Found in apps/files_external/js/statusmanager.js - About 45 mins to fix

                                      Function lazyLoadPreview has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                              lazyLoadPreview : function(path, mime, ready, width, height, etag) {
                                      Severity: Minor
                                      Found in apps/files/js/files.js - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                        if (result && result.status == 'success') {
                                    $(token).val(result.access_token);
                                    $(token_secret).val(result.access_token_secret);
                                    $(configured).val('true');
                                    OCA.External.Settings.mountConfig.saveStorageConfig($tr, function(status) {
                                        Severity: Major
                                        Found in apps/files_external/js/oauth1.js - About 45 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language