Sign upLogin

pacificclimate/climate-explorer-frontend

View on GitHub
Star
src/components/graphs/SingleTimeSliceGraph.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function SingleTimeSliceGraph has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function SingleTimeSliceGraph(props) {
  //TODO: this is 100% identical to SingleContextGraph.getMetadata(),
  //as this graph uses a subset of that one's data. Combine if possible for
  //https://github.com/pacificclimate/climate-explorer-frontend/issues/139.
  function getMetadata() {
Severity: Major
Found in src/components/graphs/SingleTimeSliceGraph.js - About 2 hrs to fix

    Function getMetadata has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function getMetadata() {
    const {
      ensemble_name,
      experiment,
      variable_id,
    Severity: Minor
    Found in src/components/graphs/SingleTimeSliceGraph.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const metadatas = uniqueContextModelIds
      .map((model_id) => ({ ...baseMetadata, model_id }))
      .filter(
        (metadata) =>
          // Note: length > 0 guaranteed for item containing props.model_id
      Severity: Major
      Found in src/components/graphs/SingleTimeSliceGraph.js and 1 other location - About 1 hr to fix
      src/components/graphs/SingleContextGraph.js on lines 42..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status