pacificclimate/climate-explorer-frontend

File chart-formatter-tests.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/******************************************************************
 * chart-formatter-tests.js - tests for chart formatting functions
 *
 * One test (sometimes with multiple parts) for each function in
 * chart-formatters.js. The tests have the same names and are in

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it("pads a graph by adding space at the bottom", function () {
    let currentMin = graph.axis.y.min;
    graph = cf.padYAxis(graph, "y", "bottom", 1);
    expect(graph.axis.y.min).toBeDefined();
    if (currentMin !== undefined) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it("pads a graph by adding space at the top", function () {
    let currentMax = graph.axis.y.max;
    graph = cf.padYAxis(graph, "y", "top", 1);
    expect(graph.axis.y.max).toBeDefined();
    if (currentMax !== undefined) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it("associates data series for a 1-axis graph", function () {
    expect(cf.getDataSeriesByAxis(oneAxis, "y").length).toBe(3);
    expect(cf.getDataSeriesByAxis(oneAxis, "y2").length).toBe(0);
    expect(cf.getDataSeriesByAxis(oneAxis, "fakeaxis").length).toBe(0);
  });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it("associates data series for a 2-axis graph", function () {
    expect(cf.getDataSeriesByAxis(twoAxes, "y").length).toBe(1);
    expect(cf.getDataSeriesByAxis(twoAxes, "y2").length).toBe(1);
    expect(cf.getDataSeriesByAxis(twoAxes, "fakeaxis").length).toBe(0);
  });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it("retains data series in the legend", function () {
    const showAll = function (series) {
      return false;
    };
    graph = cf.hideSeriesInLegend(graph, showAll);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it("removes data series from the lengend", function () {
    const hideAll = function (series) {
      return true;
    };
    graph = cf.hideSeriesInLegend(graph, hideAll);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  it("rejects horizontal padding directions", function () {
    func = function () {
      cf.padYAxis(graph, "y", "left", -1);
    };
    expect(func).toThrow();

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  it("rejects negative padding", function () {
    func = function () {
      cf.padYAxis(graph, "y", "top", -1);
    };
    expect(func).toThrow();

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  it("rejects nonexistant axes", function () {
    func = function () {
      cf.padYAxis(graph, "y1", "top", -1);
    };
    expect(func).toThrow();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    for (let i = 0; i < 3; i++) {
      if (series[0].search(resolutions[i]) != -1) {
        return i;
      }
    }

• Read up
  Read up