Sign upLogin

pacificclimate/climate-explorer-frontend

View on GitHub
Star
src/core/__tests__/chart-generator-tests.js

Summary

Maintainability
D
1 day
Test Coverage

File chart-generator-tests.js has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* ***************************************************************
 * chart-generator-tests.js - tests for chart generation functions
 *
 * One test (sometimes with multiple parts) for each function in
 * chart-generator-tests.js. The tests have the same names and are
Severity: Minor
Found in src/core/__tests__/chart-generator-tests.js - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it("rejects data sets with too many units", function () {
    let fakeData = JSON.parse(JSON.stringify(monthlyTasminTimeseries));
    fakeData.units = "meters";
    function func() {
      timeseriesToAnnualCycleGraph(
    Severity: Major
    Found in src/core/__tests__/chart-generator-tests.js and 1 other location - About 2 hrs to fix
    src/core/__tests__/chart-generator-tests.js on lines 372..384

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it("rejects data sets with too many units", function () {
    let fakeData = JSON.parse(JSON.stringify(monthlyTasminTimeseries));
    fakeData.units = "meters";
    function func() {
      timeseriesToTimeseriesGraph(
    Severity: Major
    Found in src/core/__tests__/chart-generator-tests.js and 1 other location - About 2 hrs to fix
    src/core/__tests__/chart-generator-tests.js on lines 137..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it("refuses identical data sets", function () {
    function func() {
      nameAPICallParametersFunction([{ variable: "foo" }, { variable: "foo" }]);
    }
    expect(func).toThrow();
    Severity: Major
    Found in src/core/__tests__/chart-generator-tests.js and 1 other location - About 1 hr to fix
    src/core/__tests__/chart-generator-tests.js on lines 349..357

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it("refuses data sets calculated over different areas", function () {
    function func() {
      nameAPICallParametersFunction([
        { area: "POLYGON+((-114,+-113,+-103,+-104+63,+-114+63))" },
        { area: "POLYGON+((-115,+-113,+-103,+-105+63,+-115+63))" },
    Severity: Major
    Found in src/core/__tests__/chart-generator-tests.js and 1 other location - About 1 hr to fix
    src/core/__tests__/chart-generator-tests.js on lines 343..348

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it("uses a default precision for unspecified variables", function () {
    const precision = makePrecisionBySeries({ testseries: "tasmin" });
    expect(precision(4.777, "testseries")).toEqual(4.78);
  });
    Severity: Minor
    Found in src/core/__tests__/chart-generator-tests.js and 1 other location - About 40 mins to fix
    src/core/__tests__/chart-generator-tests.js on lines 75..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      xit("reads the config file and applies its settings", function () {
    const precision = makePrecisionBySeries({ testseries: "tasmin" });
    expect(precision(4.777, "testseries")).toEqual(4.8);
  });
    Severity: Minor
    Found in src/core/__tests__/chart-generator-tests.js and 1 other location - About 40 mins to fix
    src/core/__tests__/chart-generator-tests.js on lines 79..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status