Sign upLogin

pacificclimate/climate-explorer-frontend

View on GitHub
Star
src/core/chart-generators.js

Summary

Maintainability
F
4 days
Test Coverage

File chart-generators.js has 500 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* **********************************************************************
 * chart-generators.js - functions that generate a C3 chart specification
 * object from backend query results and metadata describing the query.
 *
 * The three primary functions in this file are:
Severity: Minor
Found in src/core/chart-generators.js - About 1 day to fix

    Function assignDataToYAxis has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    function assignDataToYAxis(graph, seriesMetadata, groupByUnits = false) {
  // get sorting algorithm, if the chart already has one.
  const sortingParams = {
    y: axisSortingParams(graph, "y"),
    y2: axisSortingParams(graph, "y2"),
    Severity: Minor
    Found in src/core/chart-generators.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function assignDataToYAxis has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function assignDataToYAxis(graph, seriesMetadata, groupByUnits = false) {
  // get sorting algorithm, if the chart already has one.
  const sortingParams = {
    y: axisSortingParams(graph, "y"),
    y2: axisSortingParams(graph, "y2"),
    Severity: Major
    Found in src/core/chart-generators.js - About 2 hrs to fix

      Function dataToLongTermAverageGraph has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      function dataToLongTermAverageGraph(data, contexts = []) {
  // blank graph data object to be populated - holds data values
  // and individual-timeseries-level display options.
  let c3Data = {
    columns: [],
      Severity: Minor
      Found in src/core/chart-generators.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function dataToLongTermAverageGraph has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function dataToLongTermAverageGraph(data, contexts = []) {
  // blank graph data object to be populated - holds data values
  // and individual-timeseries-level display options.
  let c3Data = {
    columns: [],
      Severity: Major
      Found in src/core/chart-generators.js - About 2 hrs to fix

        Function timeseriesToTimeseriesGraph has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function timeseriesToTimeseriesGraph(metadata, ...data) {
  // blank graph data object to be populated - holds data values
  // and individual-timeseries-level display options.
  let c3Data = {
    columns: [],
        Severity: Major
        Found in src/core/chart-generators.js - About 2 hrs to fix

          Function timeseriesToAnnualCycleGraph has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function timeseriesToAnnualCycleGraph(metadata, ...data) {
  // blank graph data object to be populated - holds data values
  // and individual-timeseries-level display options.
  let c3Data = {
    columns: [],
          Severity: Minor
          Found in src/core/chart-generators.js - About 1 hr to fix

            Function shortestUniqueTimeseriesNamingFunction has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function shortestUniqueTimeseriesNamingFunction(metadata, data) {
  if (metadata.length === 0) {
    throw new Error("No data to show");
  }
            Severity: Minor
            Found in src/core/chart-generators.js - About 1 hr to fix

              Function getAllTimestamps has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

              function getAllTimestamps(data) {
  let allTimes = [];

  const addSeries = function (seriesData) {
    for (let timestamp in seriesData) {
              Severity: Minor
              Found in src/core/chart-generators.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function shortestUniqueTimeseriesNamingFunction has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              function shortestUniqueTimeseriesNamingFunction(metadata, data) {
  if (metadata.length === 0) {
    throw new Error("No data to show");
  }
              Severity: Minor
              Found in src/core/chart-generators.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function nameAPICallParametersFunction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function nameAPICallParametersFunction(contexts) {
  let variation = [];
  const exemplarContext = contexts[0];

  for (let context of contexts) {
              Severity: Minor
              Found in src/core/chart-generators.js - About 1 hr to fix

                Function axisSortingParams has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function axisSortingParams(graph, yAxis) {
  let params = {
    units: "",
    groupBy: { type: "", value: "" },
  };
                Severity: Minor
                Found in src/core/chart-generators.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function nameAPICallParametersFunction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function nameAPICallParametersFunction(contexts) {
  let variation = [];
  const exemplarContext = contexts[0];

  for (let context of contexts) {
                Severity: Minor
                Found in src/core/chart-generators.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function timeseriesToTimeseriesGraph has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                function timeseriesToTimeseriesGraph(metadata, ...data) {
  // blank graph data object to be populated - holds data values
  // and individual-timeseries-level display options.
  let c3Data = {
    columns: [],
                Severity: Minor
                Found in src/core/chart-generators.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    for (let att in context) {
      if (
        exemplarContext[att] !== context[att] &&
        variation.indexOf(att) === -1
      ) {
                Severity: Minor
                Found in src/core/chart-generators.js and 1 other location - About 50 mins to fix
                src/core/chart-generators.js on lines 455..462

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    for (const att of Object.getOwnPropertyNames(comparandMetadata)) {
      if (
        exemplarMetadata[att] !== comparandMetadata[att] &&
        variation.indexOf(att) === -1
      ) {
                Severity: Minor
                Found in src/core/chart-generators.js and 1 other location - About 50 mins to fix
                src/core/chart-generators.js on lines 672..679

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status