File chart-generators.js
has 498 lines of code (exceeds 250 allowed). Consider refactoring. Open
/* **********************************************************************
* chart-generators.js - functions that generate a C3 chart specification
* object from backend query results and metadata describing the query.
*
* The three primary functions in this file are:
Function assignDataToYAxis
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
function assignDataToYAxis(graph, seriesMetadata, groupByUnits = false) {
// get sorting algorithm, if the chart already has one.
const sortingParams = {
y: axisSortingParams(graph, "y"),
y2: axisSortingParams(graph, "y2"),
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function assignDataToYAxis
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
function assignDataToYAxis(graph, seriesMetadata, groupByUnits = false) {
// get sorting algorithm, if the chart already has one.
const sortingParams = {
y: axisSortingParams(graph, "y"),
y2: axisSortingParams(graph, "y2"),
Function dataToLongTermAverageGraph
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
function dataToLongTermAverageGraph(data, contexts = []) {
// blank graph data object to be populated - holds data values
// and individual-timeseries-level display options.
let c3Data = {
columns: [],
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function dataToLongTermAverageGraph
has 64 lines of code (exceeds 25 allowed). Consider refactoring. Open
function dataToLongTermAverageGraph(data, contexts = []) {
// blank graph data object to be populated - holds data values
// and individual-timeseries-level display options.
let c3Data = {
columns: [],
Function timeseriesToTimeseriesGraph
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
function timeseriesToTimeseriesGraph(metadata, ...data) {
// blank graph data object to be populated - holds data values
// and individual-timeseries-level display options.
let c3Data = {
columns: [],
Function timeseriesToAnnualCycleGraph
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
function timeseriesToAnnualCycleGraph(metadata, ...data) {
// blank graph data object to be populated - holds data values
// and individual-timeseries-level display options.
let c3Data = {
columns: [],
Function shortestUniqueTimeseriesNamingFunction
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
function shortestUniqueTimeseriesNamingFunction(metadata, data) {
if (metadata.length === 0) {
throw new Error("No data to show");
}
Function getAllTimestamps
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
function getAllTimestamps(data) {
let allTimes = [];
const addSeries = function (seriesData) {
for (let timestamp in seriesData) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function shortestUniqueTimeseriesNamingFunction
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function shortestUniqueTimeseriesNamingFunction(metadata, data) {
if (metadata.length === 0) {
throw new Error("No data to show");
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function nameAPICallParametersFunction
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function nameAPICallParametersFunction(contexts) {
let variation = [];
const exemplarContext = contexts[0];
for (let context of contexts) {
Function axisSortingParams
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
function axisSortingParams(graph, yAxis) {
let params = {
units: "",
groupBy: { type: "", value: "" },
};
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function nameAPICallParametersFunction
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
function nameAPICallParametersFunction(contexts) {
let variation = [];
const exemplarContext = contexts[0];
for (let context of contexts) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function timeseriesToTimeseriesGraph
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function timeseriesToTimeseriesGraph(metadata, ...data) {
// blank graph data object to be populated - holds data values
// and individual-timeseries-level display options.
let c3Data = {
columns: [],
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
for (const att of Object.getOwnPropertyNames(comparandMetadata)) {
if (
exemplarMetadata[att] !== comparandMetadata[att] &&
variation.indexOf(att) === -1
) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 52.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
for (let att in context) {
if (
exemplarContext[att] !== context[att] &&
variation.indexOf(att) === -1
) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 52.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76