Sign upLogin

pacificclimate/climate-explorer-frontend

View on GitHub
Star
src/core/export.js

Summary

Maintainability
D
2 days
Test Coverage

Function exportDataToWorksheet has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var exportDataToWorksheet = function (
  datatype,
  metadata,
  data,
  format,
Severity: Major
Found in src/core/export.js - About 2 hrs to fix

    Function generateDataCellsFromC3Graph has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    var generateDataCellsFromC3Graph = function (
  graph,
  seriesLabel = "Time Series",
  variable = "",
) {
    Severity: Minor
    Found in src/core/export.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generateDataCellsFromC3Graph has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var generateDataCellsFromC3Graph = function (
  graph,
  seriesLabel = "Time Series",
  variable = "",
) {
    Severity: Minor
    Found in src/core/export.js - About 1 hr to fix

      Function createTimeseriesWorksheetSummaryCells has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var createTimeseriesWorksheetSummaryCells = function (metadata, dataSpec) {
  var rows = [];
  var header = [
    "Model",
    "Emissions Scenario",
      Severity: Minor
      Found in src/core/export.js - About 1 hr to fix

        Function exportDataToWorksheet has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          datatype,
  metadata,
  data,
  format,
  selection,
        Severity: Minor
        Found in src/core/export.js - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            if (metadata.comparand_id && metadata.comparand_id !== metadata.variable_id) {
    header.push("Comparand ID");
    header.push("Comparand Name");
    values.push(metadata.comparand_id);
    values.push(metadata.comparandMeta[0].variable_name);
          Severity: Major
          Found in src/core/export.js and 1 other location - About 2 hrs to fix
          src/core/export.js on lines 210..215

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            if (metadata.comparand_id && metadata.comparand_id !== metadata.variable_id) {
    header.push("Comparand ID");
    header.push("Comparand Name");
    values.push(metadata.comparand_id);
    values.push(metadata.comparandMeta[0].variable_name);
          Severity: Major
          Found in src/core/export.js and 1 other location - About 2 hrs to fix
          src/core/export.js on lines 172..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case "stats":
      timeOfYear = timeResolutionIndexToTimeOfYear(
        selection.timescale,
        selection.timeidx,
      );
          Severity: Major
          Found in src/core/export.js and 1 other location - About 2 hrs to fix
          src/core/export.js on lines 76..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case "climoseries":
      timeOfYear = timeResolutionIndexToTimeOfYear(
        selection.timescale,
        selection.timeidx,
      );
          Severity: Major
          Found in src/core/export.js and 1 other location - About 2 hrs to fix
          src/core/export.js on lines 67..75

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status