Sign upLogin

pacificclimate/climate-explorer-frontend

View on GitHub
Star
src/core/util.js

Summary

Maintainability
C
1 day
Test Coverage

File util.js has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/***********************************************************
 * util.js - a collection of data-handling functions
 ***********************************************************/

import moment from "moment/moment";
Severity: Minor
Found in src/core/util.js - About 4 hrs to fix

    Function parseWatershedTableData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function parseWatershedTableData(data, area) {
  let avus = [];
  // convert the WKT point from the API call to geoJSON
  const point = WKTPointToGeoJSONPoint(area);
  function prec(num) {
    Severity: Minor
    Found in src/core/util.js - About 1 hr to fix

      Function timestampToTimeOfYear has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function timestampToTimeOfYear(
  timestamp,
  resolution = "monthly",
  disambiguateYear = true,
) {
      Severity: Minor
      Found in src/core/util.js - About 1 hr to fix

        Function timestampToTimeOfYear has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function timestampToTimeOfYear(
  timestamp,
  resolution = "monthly",
  disambiguateYear = true,
) {
        Severity: Minor
        Found in src/core/util.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function validateLongTermAverageData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export function validateLongTermAverageData(response) {
  if (_.isEmpty(response.data) || typeof response.data === "string") {
    throw new Error("Error: long term data unavailable for this model.");
  }
  for (const run in response.data) {
        Severity: Minor
        Found in src/core/util.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getDataUnits has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export function getDataUnits(data, variable_id) {
  const units = data.units;
  const userFriendlyUnits = getVariableOptions(
    variable_id,
    "userFriendlyUnits",
        Severity: Minor
        Found in src/core/util.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (!_.every("id units data".split(" "), (attr) => attr in response.data)) {
    throw new Error("Error: timeseries data for this model is incomplete");
  }
        Severity: Minor
        Found in src/core/util.js and 2 other locations - About 30 mins to fix
        src/core/util.js on lines 172..174
        src/core/util.js on lines 190..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (
    !_.every(
      "area elevation boundary hypsometric_curve melton_ratio".split(" "),
      (attr) => attr in response.data,
    )
        Severity: Minor
        Found in src/core/util.js and 2 other locations - About 30 mins to fix
        src/core/util.js on lines 153..155
        src/core/util.js on lines 172..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (!_.every("id units data".split(" "), (attr) => attr in response.data)) {
    throw new Error("Error: timeseries data for this model is incomplete");
  }
        Severity: Minor
        Found in src/core/util.js and 2 other locations - About 30 mins to fix
        src/core/util.js on lines 153..155
        src/core/util.js on lines 190..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status