Sign upLogin

pagseguro/magento2

View on GitHub
Star
view/frontend/web/js/model/direct-payment-validator.js

Summary

Maintainability
F
3 days
Test Coverage

Function validateCnpj has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

function validateCnpj(self) {
  var cnpj = unmask(self.value);
  var numbersVal;
  var digits;
  var sum;
Severity: Minor
Found in view/frontend/web/js/model/direct-payment-validator.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File direct-payment-validator.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * 2007-2017 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
 *
Severity: Minor
Found in view/frontend/web/js/model/direct-payment-validator.js - About 3 hrs to fix

    Function validateCpf has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    function validateCpf(self) {
  var cpf = unmask(self.value);
  var numeros, digitos, soma, i, resultado, digitos_iguais;
  digitos_iguais = 1;
  if (cpf.length < 11) {
    Severity: Minor
    Found in view/frontend/web/js/model/direct-payment-validator.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateCnpj has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function validateCnpj(self) {
  var cnpj = unmask(self.value);
  var numbersVal;
  var digits;
  var sum;
    Severity: Major
    Found in view/frontend/web/js/model/direct-payment-validator.js - About 2 hrs to fix

      Function validateCpf has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function validateCpf(self) {
  var cpf = unmask(self.value);
  var numeros, digitos, soma, i, resultado, digitos_iguais;
  digitos_iguais = 1;
  if (cpf.length < 11) {
      Severity: Minor
      Found in view/frontend/web/js/model/direct-payment-validator.js - About 1 hr to fix

        Function formataCampo has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function formataCampo(campo, Mascara, evento) {
  var boleanoMascara;

  var Digitato = evento.keyCode;
  var exp = /\-|\.|\/|\(|\)| /g;
        Severity: Minor
        Found in view/frontend/web/js/model/direct-payment-validator.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

            if (
    event.keyCode === 8 ||
    event.keyCode === 9 ||
    event.keyCode === 46 ||
    event.keyCode < 48 ||
          Severity: Major
          Found in view/frontend/web/js/model/direct-payment-validator.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if (
      e === 8 ||
      e === 9 ||
      e === 46 ||
      (e > 47 && e < 58) ||
            Severity: Major
            Found in view/frontend/web/js/model/direct-payment-validator.js - About 1 hr to fix

              Function formataCampo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              function formataCampo(campo, Mascara, evento) {
  var boleanoMascara;

  var Digitato = evento.keyCode;
  var exp = /\-|\.|\/|\(|\)| /g;
              Severity: Minor
              Found in view/frontend/web/js/model/direct-payment-validator.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Consider simplifying this complex logical expression.
              Open

                if (Digitato !== 8) {
    // backspace
    for (i = 0; i <= TamanhoMascara; i++) {
      boleanoMascara =
        Mascara.charAt(i) === '-' ||
              Severity: Major
              Found in view/frontend/web/js/model/direct-payment-validator.js - About 40 mins to fix

                Function validateDocument has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                function validateDocument(self) {
  var value = unmask(self.value);
  if (value.length === 11) {
    status = validateCpf(self);
  } else if (value.length === 14) {
                Severity: Minor
                Found in view/frontend/web/js/model/direct-payment-validator.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this function.
                Open

                    return false;
                Severity: Major
                Found in view/frontend/web/js/model/direct-payment-validator.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return false;
                  Severity: Major
                  Found in view/frontend/web/js/model/direct-payment-validator.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    if (navigator.userAgent.search('Firefox') >= 0) {
  function MascaraData(data, event) {
    if (mascaraInteiro(data) === false) {
      event.return = false;
    }
                    Severity: Major
                    Found in view/frontend/web/js/model/direct-payment-validator.js and 1 other location - About 4 hrs to fix
                    view/frontend/web/js/model/direct-payment-validator.js on lines 323..337

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 120.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    if (navigator.userAgent.search('Firefox') >= 0) {
  function creditCardMask(cc, event) {
    if (mascaraInteiro(cc) === false) {
      event.return = false;
    }
                    Severity: Major
                    Found in view/frontend/web/js/model/direct-payment-validator.js and 1 other location - About 4 hrs to fix
                    view/frontend/web/js/model/direct-payment-validator.js on lines 289..303

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 120.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        for (i = size; i >= 1; i--) {
      sum += numbersVal.charAt(size - i) * pos--;
      if (pos < 2) {
        pos = 9;
      }
                    Severity: Major
                    Found in view/frontend/web/js/model/direct-payment-validator.js and 1 other location - About 1 hr to fix
                    view/frontend/web/js/model/direct-payment-validator.js on lines 213..218

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 64.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        for (i = size; i >= 1; i--) {
      sum += numbersVal.charAt(size - i) * pos--;
      if (pos < 2) {
        pos = 9;
      }
                    Severity: Major
                    Found in view/frontend/web/js/model/direct-payment-validator.js and 1 other location - About 1 hr to fix
                    view/frontend/web/js/model/direct-payment-validator.js on lines 198..203

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 64.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status