Sign upLogin

palkan/clowne

View on GitHub
Star

Showing 4 of 6 total issues

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(reflection, source, declaration, adapter, params)
Severity: Minor
Found in lib/clowne/adapters/base/association.rb - About 35 mins to fix

    Method declarations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def declarations(reload = false)
        return @declarations if !reload && instance_variable_defined?(:@declarations)

        @declarations =
          registry.actions.flat_map do |type|
    Severity: Minor
    Found in lib/clowne/utils/plan.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method constantize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def constantize
          names = split("::")

          return nil if names.empty?
    Severity: Minor
    Found in lib/clowne/ext/string_constantize.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method match has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def match(expected, _actual)
          @actual = plan.declarations
            .find { |key, decl| key == :association && decl.name == expected }

          return false if @actual.nil?
    Severity: Minor
    Found in lib/clowne/rspec/clone_association.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language