Sign upLogin

panter/mykonote

View on GitHub
Star

Showing 4 of 6 total issues

Method run has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    doc = File.open(@enex_file) { |f| Nokogiri::XML(f) }

    doc.xpath('//note').each do |note|
      content_parts = []
Severity: Minor
Found in lib/evernote_importer.rb - About 1 hr to fix

    Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    doc = File.open(@enex_file) { |f| Nokogiri::XML(f) }

    doc.xpath('//note').each do |note|
      content_parts = []
    Severity: Minor
    Found in lib/evernote_importer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function resize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function resize(blob) {
  const image = await blobToImage(blob)

  const MAX_WIDTH = 1200
  const MAX_HEIGHT = 1200
    Severity: Minor
    Found in client/src/image.js - About 1 hr to fix

      Function resize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function resize(blob) {
  const image = await blobToImage(blob)

  const MAX_WIDTH = 1200
  const MAX_HEIGHT = 1200
      Severity: Minor
      Found in client/src/image.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language