partkeepr/PartKeepr

View on GitHub

Showing 481 of 922 total issues

Function formatParameter has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        formatParameter: function (partParameter) {
            var minSiPrefix = "", siPrefix = "", maxSiPrefix = "", unit = "", minValue = "", maxValue = "", value = "",
                minMaxCombined = "";

            if (partParameter.get("valueType") === "string")

    Function updateMenuItems has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        updateMenuItems: function (loadedState, records)
        {
    
            for (var i = 0; i < this.storeMenus.length; i++)
            {
    Severity: Major
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Ext.ux/StoreMenu.js - About 2 hrs to fix

      Function SIUnitPrefix has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          SIUnitPrefix: function( q_value, q_unit )
          {
              // the new Octopart API returns quantities as display strings: e.g. "12 mm"
              // try to recognize SI-unit and SI-prefix
              

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function onItemSave has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          onItemSave: function ()
          {
              var removeRecords = [], j, errors = [],
                  minDistributorCount = PartKeepr.getApplication().getSystemPreference(
                      "partkeepr.part.constraints.distributorCount", 0),

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function onStartEdit has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          onStartEdit: function ()
          {
              if (this.record.get("protected") === true) {
                  this.items.each(function (item) {
                      if (item instanceof Ext.form.field.Base && !(item instanceof Ext.form.field.Display)) {

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function extractJSONFilters has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private function extractJSONFilters(
              $data
          ) {
              $filter = new Filter();
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getFieldType has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          getFieldType: function (fieldName)
          {
              var ret = null, role, tmp, i;
      
              for (i=0;i<this.fields.length;i++) {
      Severity: Minor
      Found in src/PartKeepr/FrontendBundle/Resources/public/js/Data/HydraModel.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function authenticate has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function authenticate(TokenInterface $token)
          {
              $lastException = null;
              $result = null;
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function enterNode has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function enterNode(\PHPParser_Node $node)
          {
              if ($node instanceof \PHPParser_Node_Expr_MethodCall) {
                  if ($node->var->name == 'container' && $node->name == 'setParameter') {
                      if (array_key_exists(0, $node->args) && array_key_exists(1, $node->args)) {
      Severity: Minor
      Found in src/PartKeepr/SetupBundle/Visitor/ConfigVisitor.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validateConfigNode has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          validateConfigNode: function (node)
          {
              var configuration = node.data.data.configuration;
              var recurse = false;
      
      

        Method import has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function import($row, $obj = null)
            {
                $descriptions = [];
                switch ($this->importBehaviour) {
                    case self::IMPORTBEHAVIOUR_ALWAYSIMPORT:
        Severity: Major
        Found in src/PartKeepr/ImportBundle/Configuration/EntityConfiguration.php - About 2 hrs to fix

          Function createToolbar has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              createToolbar: function ()
              {
                  this.toolbarExpandButton = Ext.create("Ext.button.Button", {
                      iconCls: 'fugue-icon toggle-expand',
                      tooltip: i18n("Expand All"),

            Function getEditingContext has 59 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                getEditingContext: function (record, columnHeader)
                {
                    var me = this,
                        grid = me.grid,
                        colMgr = grid.visibleColumnManager,

              Function getAssociatedStore has 59 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  getAssociatedStore: function (inverseRecord, options, scope, records, isComplete) {
                      // Consider the Comment entity with a ticketId to a Ticket entity. The Comment
                      // is on the left (the FK holder's side) so we are implementing the guts of
                      // the comments() method to load the Store of Comment entities. This trek
                      // begins from a Ticket (inverseRecord).

                File AdvancedSearchFilter.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                namespace PartKeepr\DoctrineReflectionBundle\Filter;
                
                use Doctrine\Common\Persistence\ManagerRegistry;

                  Function initComponent has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      initComponent: function ()
                      {
                          var i;
                  
                          this.callParent(arguments);

                    Function initComponent has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        initComponent: function ()
                        {
                    
                            this.editing = Ext.create('Ext.grid.plugin.CellEditing', {
                                clicksToEdit: 1

                      Method parseConfiguration has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function parseConfiguration($importConfiguration)
                          {
                              if (!property_exists($importConfiguration, "importBehaviour")) {
                                  return false;
                      
                      
                      Severity: Major
                      Found in src/PartKeepr/ImportBundle/Configuration/ManyToOneConfiguration.php - About 2 hrs to fix

                        Method __invoke has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function __invoke(Request $request, $id)
                            {
                                list($resourceType) = $this->extractAttributes($request);
                        
                                /**
                        Severity: Major
                        Found in src/PartKeepr/BatchJobBundle/Action/ExecuteBatchJobAction.php - About 2 hrs to fix

                          Method registerBundles has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function registerBundles()
                              {
                                  // Base 3rd party bundles required for PartKeepr operation
                                  $bundles = [
                                      new Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
                          Severity: Major
                          Found in app/AppKernel.php - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language