Sign upLogin

pasosdeJesus/sivel2_gen

View on GitHub
Star
app/javascript/controllers/enviar_ficha_caso_controller.js

Summary

Maintainability
F
3 days
Test Coverage

Function cambiarficha has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

  cambiarficha(){
    if(event.target.dataset.enviarFichaCasoTarget == 'actos-pestana'){
      document.getElementById("capa-cargando").style.display = 'flex';
      if(this.requiereGuardar()){
        let casoId = this.idcasoTarget.value
Severity: Minor
Found in app/javascript/controllers/enviar_ficha_caso_controller.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cambiarficha has 126 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  cambiarficha(){
    if(event.target.dataset.enviarFichaCasoTarget == 'actos-pestana'){
      document.getElementById("capa-cargando").style.display = 'flex';
      if(this.requiereGuardar()){
        let casoId = this.idcasoTarget.value
Severity: Major
Found in app/javascript/controllers/enviar_ficha_caso_controller.js - About 5 hrs to fix

    Function actualizarGruposper has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function actualizarGruposper(s) {
      var sel = s.value;
      var cadena = '';
      var campo = document.querySelectorAll('#victimascolectivas .control-group[style!="display: none;"]');
      campo.each(function(k, v) {
    Severity: Minor
    Found in app/javascript/controllers/enviar_ficha_caso_controller.js - About 1 hr to fix

      Function connect has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        connect() {
    document.getElementById("capa-cargando").style.display = 'none';
    console.log("Conexion de controlador enviar ficha caso establecida")
    const pestanias = document.querySelectorAll('.fichacambia');
    pestanias.forEach(function(pestania) {
      Severity: Minor
      Found in app/javascript/controllers/enviar_ficha_caso_controller.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                    for (let i = 0; i < ruta.length; i++) {
              if (i === ruta.length - 1) {
                actual[ruta[i]] = value;
              } else {
                if (!actual[ruta[i]]) {
        Severity: Major
        Found in app/javascript/controllers/enviar_ficha_caso_controller.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (typeof nom === 'undefined') {
          nom = $(v).find('div').filter(function() {
            return this.attributes.class.value.match(/grupoper_nombre/);
          }).find('input').val();
        }
          Severity: Major
          Found in app/javascript/controllers/enviar_ficha_caso_controller.js and 1 other location - About 2 hrs to fix
          app/javascript/controllers/enviar_ficha_caso_controller.js on lines 171..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (typeof id === 'undefined') {
          id = $(v).find('div').filter(function() {
            return this.attributes.class.value.match(/grupoper_id/);
          }).find('input').val();
        }
          Severity: Major
          Found in app/javascript/controllers/enviar_ficha_caso_controller.js and 1 other location - About 2 hrs to fix
          app/javascript/controllers/enviar_ficha_caso_controller.js on lines 183..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
          pestania.classList.remove('active');
          const atributoId = pestania.getAttribute('data-bs-target');
          const atributo = document.querySelector(atributoId);
          if (atributo) {
          Severity: Major
          Found in app/javascript/controllers/enviar_ficha_caso_controller.js and 1 other location - About 1 hr to fix
          app/javascript/controllers/enviar_ficha_caso_controller.js on lines 19..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (pestania.id == pestanaActiva) {
          pestania.classList.add('active');
          const atributoId = pestania.getAttribute('data-bs-target');
          const atributo = document.querySelector(atributoId);
          if (atributo) {
          Severity: Major
          Found in app/javascript/controllers/enviar_ficha_caso_controller.js and 1 other location - About 1 hr to fix
          app/javascript/controllers/enviar_ficha_caso_controller.js on lines 26..33

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  var nom = $(v).find('div').filter(function() {
          return this.attributes.class.value.match(/caso_victimacolectiva[_0-9]*grupoper_nombre/);
        }).find('input').val();
          Severity: Major
          Found in app/javascript/controllers/enviar_ficha_caso_controller.js and 1 other location - About 1 hr to fix
          app/javascript/controllers/enviar_ficha_caso_controller.js on lines 168..170

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  var id = $(v).find('div').filter(function() {
          return this.attributes.class.value.match(/caso_victimacolectiva[_0-9]*grupoper_id/);
        }).find('input').val();
          Severity: Major
          Found in app/javascript/controllers/enviar_ficha_caso_controller.js and 1 other location - About 1 hr to fix
          app/javascript/controllers/enviar_ficha_caso_controller.js on lines 180..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status