Sign upLogin

passport-next/passport-http

View on GitHub
Star

Showing 10 of 14 total issues

Function authenticate has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

DigestStrategy.prototype.authenticate = function(req) {
  var authorization = req.headers['authorization'];
  if (!authorization) { return this.fail(this._challenge()); }
  
  var parts = authorization.split(' ')
Severity: Major
Found in lib/passport-http/strategies/digest.js - About 2 hrs to fix

    Function authenticate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    BasicStrategy.prototype.authenticate = function(req) {
  var authorization = req.headers['authorization'];
  if (!authorization) { return this.fail(this._challenge()); }
  
  var parts = authorization.split(' ')
    Severity: Minor
    Found in lib/passport-http/strategies/basic.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function DigestStrategy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function DigestStrategy(options, secret, validate) {
  if (typeof options == 'function') {
    validate = secret;
    secret = options;
    options = {};
    Severity: Minor
    Found in lib/passport-http/strategies/digest.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return this.fail(this._challenge());
    Severity: Major
    Found in lib/passport-http/strategies/basic.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return self.fail(400);
      Severity: Major
      Found in lib/passport-http/strategies/digest.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return self.fail(self._challenge());
        Severity: Major
        Found in lib/passport-http/strategies/digest.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return this.fail(400);
          Severity: Major
          Found in lib/passport-http/strategies/digest.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return self.fail(400);
            Severity: Major
            Found in lib/passport-http/strategies/digest.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return this.fail(this._challenge());
              Severity: Major
              Found in lib/passport-http/strategies/digest.js - About 30 mins to fix

                Function authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                DigestStrategy.prototype.authenticate = function(req) {
  var authorization = req.headers['authorization'];
  if (!authorization) { return this.fail(this._challenge()); }
  
  var parts = authorization.split(' ')
                Severity: Minor
                Found in lib/passport-http/strategies/digest.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language