Sign upLogin

pat310/quick-pivot

View on GitHub
Star
src/logic.js

Summary

Maintainability
F
4 days
Test Coverage

Function tableCreator has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
Open

export function tableCreator(data, rows = [], cols = [], accCatOrCB,
  accTypeOrInitVal, rowHeader, columnSortFunc) {

  /** if data is empty, return empty array */
  if (data.length === 0) {
Severity: Minor
Found in src/logic.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function tableCreator has 205 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function tableCreator(data, rows = [], cols = [], accCatOrCB,
  accTypeOrInitVal, rowHeader, columnSortFunc) {

  /** if data is empty, return empty array */
  if (data.length === 0) {
Severity: Major
Found in src/logic.js - About 1 day to fix

    File logic.js has 355 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * @file Contains logic to actually pivot data
*/

/**
    Severity: Minor
    Found in src/logic.js - About 4 hrs to fix

      Function rowRecurse has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function rowRecurse(rowGroups, depth, rowHeaders = []) {
    for (const key in rowGroups) {
      if (Array.isArray(rowGroups[key])) {
        const recursedData = groupByCategories(rowGroups[key], cols);
      Severity: Major
      Found in src/logic.js - About 2 hrs to fix

        Function fixDataFormat has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function fixDataFormat(data, rows = [], sortFunc) {
  if (!Array.isArray(data) || !data.length) return [];

  let formattedData = [];
        Severity: Minor
        Found in src/logic.js - About 1 hr to fix

          Function recurseThroughMap has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  (function recurseThroughMap(dataPos, map) {
          if (Array.isArray(dataPos)) {
            if (key === prevKey) {
              const datum = dataRows[dataRows.length - 1].value;
          Severity: Minor
          Found in src/logic.js - About 1 hr to fix

            Function accumulator has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function accumulator(arr, accCat, accType, accValue) {
  if (typeof accCat === 'undefined') accType = 'count';
  else if (typeof accCat === 'function') accValue = accType || 0;

  return arr.reduce((acc, curr, index, array) => {
            Severity: Minor
            Found in src/logic.js - About 1 hr to fix

              Function createColumnHeaders has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              export function createColumnHeaders(
  data,
  cols = [],
  firstColumn = '',
  columnSortFunc = () => () => {}
              Severity: Minor
              Found in src/logic.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function fixDataFormat has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              export function fixDataFormat(data, rows = [], sortFunc) {
  if (!Array.isArray(data) || !data.length) return [];

  let formattedData = [];
              Severity: Minor
              Found in src/logic.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function tableCreator has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              export function tableCreator(data, rows = [], cols = [], accCatOrCB,
  accTypeOrInitVal, rowHeader, columnSortFunc) {
              Severity: Major
              Found in src/logic.js - About 50 mins to fix

                Avoid too many return statements within this function.
                Open

                        return acc;
                Severity: Major
                Found in src/logic.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return acc;
                  Severity: Major
                  Found in src/logic.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return acc;
                    Severity: Major
                    Found in src/logic.js - About 30 mins to fix

                      TODO found
                      Open

                              // TODO: Investigate why type is coming up as 0
                      Severity: Minor
                      Found in src/logic.js by fixme

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                            case ('max'): {
        if (index === 0) acc = Number(curr[accCat]);
        else if (curr[accCat] > acc) acc = Number(curr[accCat]);

        return acc;
                      Severity: Major
                      Found in src/logic.js and 1 other location - About 1 hr to fix
                      src/logic.js on lines 200..205

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 61.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                            case ('min'): {
        if (index === 0) acc = Number(curr[accCat]);
        else if (curr[accCat] < acc) acc = Number(curr[accCat]);

        return acc;
                      Severity: Major
                      Found in src/logic.js and 1 other location - About 1 hr to fix
                      src/logic.js on lines 207..212

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 61.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status