patapizza/COP-Ruby

View on GitHub

Showing 3 of 3 total issues

Class Context has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class Context

  @@default = nil
  @@stack = Array.new

Severity: Minor
Found in cop/context.rb - About 2 hrs to fix

    Method hang_up has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def hang_up(*args)
        if args.size == 0
          raise Exception if self.active_call.nil?
          self.hang_up(@active_call)
        else
    Severity: Minor
    Found in phone/phone.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method answer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def answer(*args)
        if args.size == 0
          next_call = @incoming_calls[0]
          raise Exception if next_call.nil?
          self.answer(next_call)
    Severity: Minor
    Found in phone/phone.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language