Sign upLogin

patternfly/angular-patternfly

View on GitHub
Star
src/modals/modal-overlay/modal-overlay.component.js

Summary

Maintainability
C
1 day
Test Coverage

Function controller has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    controller: function ( $uibModal ) {
      'use strict';

      var ctrl = this;
      var modalInstance;
Severity: Major
Found in src/modals/modal-overlay/modal-overlay.component.js - About 2 hrs to fix

    Function open has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          ctrl.open = function () {
        modalInstance = $uibModal.open({
          component: 'pfModalOverlayContent',
          backdrop: ctrl.backgroundClose ? true : 'static',
          resolve: {
    Severity: Minor
    Found in src/modals/modal-overlay/modal-overlay.component.js - About 1 hr to fix

      Function controller has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        controller: function ($scope) {
    'use strict';
    var ctrl = this;

    ctrl.$onInit = function () {
      Severity: Minor
      Found in src/modals/modal-overlay/modal-overlay.component.js - About 1 hr to fix

        Function controller has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          controller: function ($scope) {
    'use strict';
    var ctrl = this;

    ctrl.$onInit = function () {
        Severity: Minor
        Found in src/modals/modal-overlay/modal-overlay.component.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function controller has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            controller: function ( $uibModal ) {
      'use strict';

      var ctrl = this;
      var modalInstance;
        Severity: Minor
        Found in src/modals/modal-overlay/modal-overlay.component.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function $onInit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            ctrl.$onInit = function () {
      ctrl.modalId = ctrl.resolve.modalId;
      ctrl.titleId = ctrl.resolve.titleId || "modalTitle";
      ctrl.modalTitle = ctrl.resolve.modalTitle;
      ctrl.hideCloseIcon = ctrl.resolve.hideCloseIcon || false;
        Severity: Minor
        Found in src/modals/modal-overlay/modal-overlay.component.js - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status