paypay/paypayopa-sdk-php

View on GitHub

Showing 7 of 15 total issues

Function validate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate($throwErrors = true)
    {
        $faults = [];
        $iterable = get_object_vars($this);
        foreach ($this->descriptor as $memberName => $memberInfo) {
Severity: Minor
Found in src/core/Model.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doCall has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function doCall($lookupApi, $apiId, $url, $data, $options)
    {
        if ($lookupApi) {
            $apiInfo = $this->main()->GetApiMapping($apiId);
            $callType = strtolower($apiInfo["method"]);
Severity: Minor
Found in src/core/Controller.php - About 1 hr to fix

    Function doCall has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function doCall($lookupApi, $apiId, $url, $data, $options)
        {
            if ($lookupApi) {
                $apiInfo = $this->main()->GetApiMapping($apiId);
                $callType = strtolower($apiInfo["method"]);
    Severity: Minor
    Found in src/core/Controller.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($auth = null, $productionmode = false, $requestHandler = false)
        {
            if (!isset($auth['API_KEY']) || !isset($auth['API_SECRET'])) {
                throw new ClientException("Invalid auth credentials", 1);
            }
    Severity: Minor
    Found in src/Client.php - About 1 hr to fix

      Method PayPayEncryptHeader has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function PayPayEncryptHeader($apiKey, $apiSecret, $method, $resource, $contentType, $payload)
      Severity: Minor
      Found in src/helpers/utility_hmac.php - About 45 mins to fix

        Method doCall has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function doCall($lookupApi, $apiId, $url, $data, $options)
        Severity: Minor
        Found in src/core/Controller.php - About 35 mins to fix

          Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct($auth = null, $productionmode = false, $requestHandler = false)
              {
                  if (!isset($auth['API_KEY']) || !isset($auth['API_SECRET'])) {
                      throw new ClientException("Invalid auth credentials", 1);
                  }
          Severity: Minor
          Found in src/Client.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language