Sign upLogin

pbakondy/cordova-plugin-sim

View on GitHub
Star

Showing 4 of 4 total issues

Method execute has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  @SuppressLint("HardwareIds")
  @Override
  public boolean execute(String action, JSONArray args, CallbackContext callbackContext) throws JSONException {
    callback = callbackContext;
Severity: Minor
Found in src/android/com/pbakondy/Sim.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  @SuppressLint("HardwareIds")
  @Override
  public boolean execute(String action, JSONArray args, CallbackContext callbackContext) throws JSONException {
    callback = callbackContext;
Severity: Major
Found in src/android/com/pbakondy/Sim.java - About 5 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                  if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
                deviceId = manager.getDeviceId(simSlotIndex);
              }
    Severity: Major
    Found in src/android/com/pbakondy/Sim.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                    if (deviceId != null) {
                simData.put("deviceId", deviceId);
              }
      Severity: Major
      Found in src/android/com/pbakondy/Sim.java - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language