Sign upLogin

pencil-js/pencil.js

View on GitHub
Star
src/modules/container/container.js

Summary

Maintainability
C
1 day
Test Coverage
A
100%

Container has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class Container extends EventEmitter {
    /**
     * Container constructor
     * @param {PositionDefinition} [positionDefinition] - Position in its container
     * @param {ContainerOptions} [options] - Specific options
Severity: Minor
Found in src/modules/container/container.js - About 2 hrs to fix

    File container.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import EventEmitter from "@pencil.js/event-emitter";
import BaseEvent from "@pencil.js/base-event";
import Position from "@pencil.js/position";
import { radianCircle } from "@pencil.js/math";
    Severity: Minor
    Found in src/modules/container/container.js - About 2 hrs to fix

      Function setContext has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          setContext (ctx) {
        if (this.options.clip) {
            const clipping = new window.Path2D();
            const { clip } = this.options;
            const { x, y } = clip.position;
      Severity: Minor
      Found in src/modules/container/container.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setContext has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setContext (ctx) {
        if (this.options.clip) {
            const clipping = new window.Path2D();
            const { clip } = this.options;
            const { x, y } = clip.position;
      Severity: Minor
      Found in src/modules/container/container.js - About 1 hr to fix

        Function getTarget has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            getTarget (position, ctx) {
        if (!this.options.shown) {
            return null;
        }
        Severity: Minor
        Found in src/modules/container/container.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            show () {
        this.options.shown = true;
        this.fire(new BaseEvent(Container.events.show, this));
        return this;
    }
        Severity: Minor
        Found in src/modules/container/container.js and 1 other location - About 55 mins to fix
        src/modules/container/container.js on lines 343..347

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            hide () {
        this.options.shown = false;
        this.fire(new BaseEvent(Container.events.hide, this));
        return this;
    }
        Severity: Minor
        Found in src/modules/container/container.js and 1 other location - About 55 mins to fix
        src/modules/container/container.js on lines 333..337

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (typeof this.options.scale !== "number") {
            this.options.scale = Position.from(this.options.scale);
        }
        Severity: Minor
        Found in src/modules/container/container.js and 1 other location - About 50 mins to fix
        src/modules/component/component.js on lines 54..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status